Skip to content

Conversation

dustinfreeman
Copy link

@dustinfreeman dustinfreeman commented Feb 3, 2025

Summary

Following the iOS Demo app instructions generates files that are not tracked in version control. This updates the main .gitignore, and adds a new .gitignore specific to the generated iOS Xcode project.

Test plan

This has been tested, in the sense that I have run through the instructions to the end of the iOS demo without issue, and only needed to make the .gitignore changes so I didn't have the build artifacts appear as untracked in version control.

26D0E049-8212-4FB5-B8D1-32EA88A3FF83_4_5005_c

It is possible these changes may lead to undesired effects in esoteric unofficial workflows with this repo, but I can't know that unless someone speaks up about it. I couldn't find any prior discussion about this.

Copy link

pytorch-bot bot commented Feb 3, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/8153

Note: Links to docs will display an error until the docs builds have been completed.

❗ 1 Active SEVs

There are 1 currently active SEVs. If your PR is affected, please view them below:

✅ No Failures

As of commit e4dd77a with merge base 9de4c16 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Feb 3, 2025
@dustinfreeman dustinfreeman changed the title Gitignore ios .gitignores for ios demo artifacts Feb 3, 2025
@dustinfreeman
Copy link
Author

@pytorchbot label "topic: not user facing"

@digantdesai
Copy link
Contributor

Looks good to me. Can you rebase please?
cc @shoumikhin

@dustinfreeman dustinfreeman force-pushed the gitignore-ios branch 2 times, most recently from 98de889 to 519ac94 Compare February 6, 2025 18:46
@dustinfreeman
Copy link
Author

Looks good to me. Can you rebase please? cc @shoumikhin

I'm having to manually rebase each time new commits come up on the main branch. You have my permission to rebase it yourself whenever you do the final review.

Copy link

Looks like this PR hasn't been updated in a while so we're going to go ahead and mark this as Stale.
Feel free to remove the Stale label if you feel this was a mistake.
If you are unable to remove the Stale label please contact a maintainer in order to do so.
If you want the bot to never mark this PR stale again, add the no-stale label.
Stale pull requests will automatically be closed after 30 days of inactivity.

@github-actions github-actions bot added the stale PRs inactive for over 60 days label Aug 30, 2025
Copy link

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

@shoumikhin
Copy link
Contributor

This demo app now lives at https://github.com/meta-pytorch/executorch-examples/tree/main/mv3/apple/ExecuTorchDemo

@nil-is-all nil-is-all removed the stale PRs inactive for over 60 days label Sep 3, 2025
@nil-is-all
Copy link
Contributor

This demo app now lives at https://github.com/meta-pytorch/executorch-examples/tree/main/mv3/apple/ExecuTorchDemo

@shoumikhin confirming this PR can be closed now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. topic: not user facing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants