Add tosa serializer to .mypy.ini #8133
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/8133
Note: Links to docs will display an error until the docs builds have been completed. ✅ You can merge normally! (2 Unrelated Failures)As of commit 5fd5a7e with merge base a5c7609 ( BROKEN TRUNK - The following jobs failed but were present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
perheld
added
topic: not user facing
and removed
CLA Signed
|
@pytorchbot label ciflow/trunk |
perheld
added
the
partner: arm
zingo
approved these changes
Feb 3, 2025
facebook-github-bot
added
the
CLA Signed
As suggested in a previous discussion the tosa serializer should go into .mypy.ini for a project wide ignore on missing imports instead of doing inline annotations in every file. Change-Id: I3ea00d0ff586d0f68a2c0fc557a2296cd03f3b04
perheld
force-pushed
the
upstream/ph-mypy-ini-tosa-serialiser
branch
from
4d19888 to
5fd5a7e
Compare
This was referenced Feb 11, 2025
This was referenced Feb 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As suggested in a previous discussion the tosa serializer should go into .mypy.ini for a project wide ignore on missing imports instead of doing inline annotations in every file.
cc @digantdesai @freddan80 @per @zingo @oscarandersson8218