Single location to update optional args for all attentions #8128
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: Incremental improvement on the UX. When users need to add an optional argument for a new attention, there's this centralized location, `ForwardOptions` to be updated. Differential Revision: D68988021
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/8128
Note: Links to docs will display an error until the docs builds have been completed. ✅ You can merge normally! (2 Unrelated Failures)As of commit 1273002 with merge base a972e73 ( BROKEN TRUNK - The following jobs failed but were present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D68988021 |
tarun292
approved these changes
Feb 1, 2025
|
@pytorchbot label "topic: not user facing" |
sxu
added a commit
to sxu/executorch
that referenced
this pull request
Feb 4, 2025
…t state as output Summary: Pass a `ForwardOptions` argument (introduced by pytorch#8128) from the top level transformer, consolidate some existing inputs into it, and return any optional updates from the attention implementation. Differential Revision: D69080123
sxu
added a commit
to sxu/executorch
that referenced
this pull request
Feb 4, 2025
…t state as output (pytorch#8186) Summary: Pass a `ForwardOptions` argument (introduced by pytorch#8128) from the top level transformer, consolidate some existing inputs into it, and return any optional updates from the attention implementation. Reviewed By: iseeyuan Differential Revision: D69080123
sxu
added a commit
to sxu/executorch
that referenced
this pull request
Feb 4, 2025
…t state as output (pytorch#8186) Summary: Pass a `ForwardOptions` argument (introduced by pytorch#8128) from the top level transformer, consolidate some existing inputs into it, and return any optional updates from the attention implementation. Reviewed By: iseeyuan Differential Revision: D69080123
sxu
added a commit
to sxu/executorch
that referenced
this pull request
Feb 4, 2025
…t state as output (pytorch#8186) Summary: Pass a `ForwardOptions` argument (introduced by pytorch#8128) from the top level transformer, consolidate some existing inputs into it, and return any optional updates from the attention implementation. Reviewed By: iseeyuan Differential Revision: D69080123
sxu
added a commit
to sxu/executorch
that referenced
this pull request
Feb 4, 2025
…t state as output (pytorch#8186) Summary: Pass a `ForwardOptions` argument (introduced by pytorch#8128) from the top level transformer, consolidate some existing inputs into it, and return any optional updates from the attention implementation. Reviewed By: iseeyuan Differential Revision: D69080123
sxu
added a commit
to sxu/executorch
that referenced
this pull request
Feb 4, 2025
…t state as output (pytorch#8186) Summary: Pass a `ForwardOptions` argument (introduced by pytorch#8128) from the top level transformer, consolidate some existing inputs into it, and return any optional updates from the attention implementation. Reviewed By: iseeyuan Differential Revision: D69080123
sxu
added a commit
to sxu/executorch
that referenced
this pull request
Feb 4, 2025
…t state as output (pytorch#8186) Summary: Pass a `ForwardOptions` argument (introduced by pytorch#8128) from the top level transformer, consolidate some existing inputs into it, and return any optional updates from the attention implementation. Reviewed By: iseeyuan Differential Revision: D69080123
sxu
added a commit
to sxu/executorch
that referenced
this pull request
Feb 4, 2025
…t state as output (pytorch#8186) Summary: Pass a `ForwardOptions` argument (introduced by pytorch#8128) from the top level transformer, consolidate some existing inputs into it, and return any optional updates from the attention implementation. Reviewed By: iseeyuan Differential Revision: D69080123
sxu
added a commit
to sxu/executorch
that referenced
this pull request
Feb 5, 2025
…t state as output (pytorch#8186) Summary: Pass a `ForwardOptions` argument (introduced by pytorch#8128) from the top level transformer, consolidate some existing inputs into it, and return any optional updates from the attention implementation. Reviewed By: iseeyuan Differential Revision: D69080123
sxu
added a commit
to sxu/executorch
that referenced
this pull request
Feb 5, 2025
…t state as output (pytorch#8186) Summary: Pass a `ForwardOptions` argument (introduced by pytorch#8128) from the top level transformer, consolidate some existing inputs into it, and return any optional updates from the attention implementation. Reviewed By: iseeyuan Differential Revision: D69080123
sxu
added a commit
to sxu/executorch
that referenced
this pull request
Feb 5, 2025
…t state as output (pytorch#8186) Summary: Pass a `ForwardOptions` argument (introduced by pytorch#8128) from the top level transformer, consolidate some existing inputs into it, and return any optional updates from the attention implementation. Reviewed By: iseeyuan Differential Revision: D69080123
sxu
added a commit
to sxu/executorch
that referenced
this pull request
Feb 5, 2025
…t state as output (pytorch#8186) Summary: Pass a `ForwardOptions` argument (introduced by pytorch#8128) from the top level transformer, consolidate some existing inputs into it, and return any optional updates from the attention implementation. Reviewed By: iseeyuan Differential Revision: D69080123
sxu
added a commit
to sxu/executorch
that referenced
this pull request
Feb 5, 2025
…t state as output (pytorch#8186) Summary: Pass a `ForwardOptions` argument (introduced by pytorch#8128) from the top level transformer, consolidate some existing inputs into it, and return any optional updates from the attention implementation. Reviewed By: iseeyuan Differential Revision: D69080123
sxu
added a commit
to sxu/executorch
that referenced
this pull request
Feb 5, 2025
…t state as output (pytorch#8186) Summary: Pass a `ForwardOptions` argument (introduced by pytorch#8128) from the top level transformer, consolidate some existing inputs into it, and return any optional updates from the attention implementation. Reviewed By: iseeyuan Differential Revision: D69080123
sxu
added a commit
to sxu/executorch
that referenced
this pull request
Feb 5, 2025
…t state as output (pytorch#8186) Summary: Pass a `ForwardOptions` argument (introduced by pytorch#8128) from the top level transformer, consolidate some existing inputs into it, and return any optional updates from the attention implementation. Reviewed By: iseeyuan, cccclai Differential Revision: D69080123
sxu
added a commit
to sxu/executorch
that referenced
this pull request
Feb 6, 2025
…t state as output (pytorch#8186) Summary: Pass a `ForwardOptions` argument (introduced by pytorch#8128) from the top level transformer, consolidate some existing inputs into it, and return any optional updates from the attention implementation. Reviewed By: iseeyuan, cccclai Differential Revision: D69080123
sxu
added a commit
to sxu/executorch
that referenced
this pull request
Feb 6, 2025
…t state as output (pytorch#8186) Summary: Pass a `ForwardOptions` argument (introduced by pytorch#8128) from the top level transformer, consolidate some existing inputs into it, and return any optional updates from the attention implementation. Reviewed By: iseeyuan, cccclai Differential Revision: D69080123
sxu
added a commit
to sxu/executorch
that referenced
this pull request
Feb 6, 2025
…t state as output (pytorch#8186) Summary: Pass a `ForwardOptions` argument (introduced by pytorch#8128) from the top level transformer, consolidate some existing inputs into it, and return any optional updates from the attention implementation. Reviewed By: iseeyuan, cccclai Differential Revision: D69080123
This was referenced Feb 11, 2025
This was referenced Feb 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: Incremental improvement on the UX. When users need to add an optional argument for a new attention, there's this centralized location,
ForwardOptionsto be updated.Differential Revision: D68988021