Restore std::array constructors for ArrayRef #7942
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/7942
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 0a04883 with merge base 7600f18 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
This was referenced Jan 24, 2025
|
is this to match array ref functionality in pt core? |
yes, it is a manual partial revert of D35259739 |
kimishpatel
approved these changes
Jan 28, 2025
YIWENX14
pushed a commit
that referenced
this pull request
Jan 28, 2025
Checked with @suo, shouldn't be any reason to keep these gone. Manual partial revert of D35259739.
zonglinpeng
pushed a commit
to zonglinpeng/executorch
that referenced
this pull request
Jan 30, 2025
Checked with @suo, shouldn't be any reason to keep these gone. Manual partial revert of D35259739.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checked with @suo, shouldn't be any reason to keep these gone.