Replace pytree_assert with production pytree_check. Remove pytree_unreachable #7655
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eachable When handling untrusted input, it's not appropriate to use debug-only checks; we should be checking in prod as these are not programmer errors. pytree_unreachable was similarly being used for input validation. Differential Revision: [D68166301](https://our.internmc.facebook.com/intern/diff/D68166301/) [ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/7655
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 73ce658 with merge base b362ab7 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
This was referenced Jan 14, 2025
swolchok
pushed a commit
that referenced
this pull request
Jan 14, 2025
…eachable When handling untrusted input, it's not appropriate to use debug-only checks; we should be checking in prod as these are not programmer errors. pytree_unreachable was similarly being used for input validation. Differential Revision: [D68166301](https://our.internmc.facebook.com/intern/diff/D68166301/) ghstack-source-id: 261377457 Pull Request resolved: #7655
|
This pull request was exported from Phabricator. Differential Revision: D68166301 |
… pytree_unreachable" When handling untrusted input, it's not appropriate to use debug-only checks; we should be checking in prod as these are not programmer errors. pytree_unreachable was similarly being used for input validation. Differential Revision: [D68166301](https://our.internmc.facebook.com/intern/diff/D68166301/) [ghstack-poisoned]
swolchok
added a commit
that referenced
this pull request
Jan 17, 2025
…eachable Pull Request resolved: #7655 When handling untrusted input, it's not appropriate to use debug-only checks; we should be checking in prod as these are not programmer errors. pytree_unreachable was similarly being used for input validation. ghstack-source-id: 261987906 Differential Revision: [D68166301](https://our.internmc.facebook.com/intern/diff/D68166301/)
|
This pull request was exported from Phabricator. Differential Revision: D68166301 |
… pytree_unreachable" When handling untrusted input, it's not appropriate to use debug-only checks; we should be checking in prod as these are not programmer errors. pytree_unreachable was similarly being used for input validation. Differential Revision: [D68166301](https://our.internmc.facebook.com/intern/diff/D68166301/) [ghstack-poisoned]
|
This pull request was exported from Phabricator. Differential Revision: D68166301 |
swolchok
added a commit
that referenced
this pull request
Jan 18, 2025
…eachable Pull Request resolved: #7655 When handling untrusted input, it's not appropriate to use debug-only checks; we should be checking in prod as these are not programmer errors. pytree_unreachable was similarly being used for input validation. ghstack-source-id: 262028959 Differential Revision: [D68166301](https://our.internmc.facebook.com/intern/diff/D68166301/)
dbort
approved these changes
Jan 22, 2025
extension/pytree/pybindings.cpp
Outdated
| @@ -145,7 +145,8 @@ class PyTree { | |||
| } else if (py::isinstance<py::int_>(key)) { | |||
| s.key(i) = py::cast<int32_t>(key); | |||
| } else { | |||
| pytree_assert(false); | |||
| throw std::runtime_err( | |||
| "invalid key in pytree dict; must be int or string"); | |||
There was a problem hiding this comment.
It'd be helpful to print the key type here, though the old code didn't do it either so not a blocker. Similar for other new throw messages in this PR.
… pytree_unreachable" When handling untrusted input, it's not appropriate to use debug-only checks; we should be checking in prod as these are not programmer errors. pytree_unreachable was similarly being used for input validation. Differential Revision: [D68166301](https://our.internmc.facebook.com/intern/diff/D68166301/) [ghstack-poisoned]
swolchok
added a commit
that referenced
this pull request
Jan 23, 2025
…eachable Pull Request resolved: #7655 When handling untrusted input, it's not appropriate to use debug-only checks; we should be checking in prod as these are not programmer errors. pytree_unreachable was similarly being used for input validation. ghstack-source-id: 262806899 Differential Revision: [D68166301](https://our.internmc.facebook.com/intern/diff/D68166301/)
|
This pull request was exported from Phabricator. Differential Revision: D68166301 |
… pytree_unreachable" When handling untrusted input, it's not appropriate to use debug-only checks; we should be checking in prod as these are not programmer errors. pytree_unreachable was similarly being used for input validation. Differential Revision: [D68166301](https://our.internmc.facebook.com/intern/diff/D68166301/) [ghstack-poisoned]
|
This pull request was exported from Phabricator. Differential Revision: D68166301 |
swolchok
added a commit
that referenced
this pull request
Jan 31, 2025
…eachable Pull Request resolved: #7655 When handling untrusted input, it's not appropriate to use debug-only checks; we should be checking in prod as these are not programmer errors. pytree_unreachable was similarly being used for input validation. ghstack-source-id: 263972123 Differential Revision: [D68166301](https://our.internmc.facebook.com/intern/diff/D68166301/)
… pytree_unreachable" When handling untrusted input, it's not appropriate to use debug-only checks; we should be checking in prod as these are not programmer errors. pytree_unreachable was similarly being used for input validation. Differential Revision: [D68166301](https://our.internmc.facebook.com/intern/diff/D68166301/) [ghstack-poisoned]
swolchok
pushed a commit
that referenced
this pull request
Feb 6, 2025
…eachable Pull Request resolved: #7655 When handling untrusted input, it's not appropriate to use debug-only checks; we should be checking in prod as these are not programmer errors. pytree_unreachable was similarly being used for input validation. ghstack-source-id: 265152270 Differential Revision: [D68166301](https://our.internmc.facebook.com/intern/diff/D68166301/)
|
This pull request was exported from Phabricator. Differential Revision: D68166301 |
facebook-github-bot
temporarily deployed
to
cherry-pick-bot
GitHub Actions
Inactive
kirklandsign
pushed a commit
that referenced
this pull request
Feb 7, 2025
…eachable Pull Request resolved: #7655 When handling untrusted input, it's not appropriate to use debug-only checks; we should be checking in prod as these are not programmer errors. pytree_unreachable was similarly being used for input validation. ghstack-source-id: 265152270 Differential Revision: [D68166301](https://our.internmc.facebook.com/intern/diff/D68166301/)
kirklandsign
pushed a commit
that referenced
this pull request
Feb 7, 2025
…eachable Pull Request resolved: #7655 When handling untrusted input, it's not appropriate to use debug-only checks; we should be checking in prod as these are not programmer errors. pytree_unreachable was similarly being used for input validation. ghstack-source-id: 265152270 Differential Revision: [D68166301](https://our.internmc.facebook.com/intern/diff/D68166301/) Co-authored-by: Github Executorch <github_executorch@arm.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
When handling untrusted input, it's not appropriate to use debug-only checks; we should be checking in prod as these are not programmer errors. pytree_unreachable was similarly being used for input validation.
Differential Revision: D68166301