add a bunch of bounds checking to pytree #7654
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's possible to pass arbitrary string input to pytree from Python; let's not have a bunch of low-hanging memory safety issues. Differential Revision: [D68166303](https://our.internmc.facebook.com/intern/diff/D68166303/) [ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/7654
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 46811f0 with merge base b362ab7 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D68166303 |
This was referenced Jan 14, 2025
It's possible to pass arbitrary string input to pytree from Python; let's not have a bunch of low-hanging memory safety issues. Differential Revision: [D68166303](https://our.internmc.facebook.com/intern/diff/D68166303/) [ghstack-poisoned]
|
This pull request was exported from Phabricator. Differential Revision: D68166303 |
It's possible to pass arbitrary string input to pytree from Python; let's not have a bunch of low-hanging memory safety issues. Differential Revision: [D68166303](https://our.internmc.facebook.com/intern/diff/D68166303/) [ghstack-poisoned]
|
This pull request was exported from Phabricator. Differential Revision: D68166303 |
IvanKobzarev
approved these changes
Jan 21, 2025
It's possible to pass arbitrary string input to pytree from Python; let's not have a bunch of low-hanging memory safety issues. Differential Revision: [D68166303](https://our.internmc.facebook.com/intern/diff/D68166303/) [ghstack-poisoned]
|
This pull request was exported from Phabricator. Differential Revision: D68166303 |
It's possible to pass arbitrary string input to pytree from Python; let's not have a bunch of low-hanging memory safety issues. Differential Revision: [D68166303](https://our.internmc.facebook.com/intern/diff/D68166303/) [ghstack-poisoned]
|
This pull request was exported from Phabricator. Differential Revision: D68166303 |
It's possible to pass arbitrary string input to pytree from Python; let's not have a bunch of low-hanging memory safety issues. Differential Revision: [D68166303](https://our.internmc.facebook.com/intern/diff/D68166303/) [ghstack-poisoned]
|
This pull request was exported from Phabricator. Differential Revision: D68166303 |
facebook-github-bot
temporarily deployed
to
cherry-pick-bot
GitHub Actions
Inactive
kirklandsign
pushed a commit
that referenced
this pull request
Feb 7, 2025
Pull Request resolved: #7654 It's possible to pass arbitrary string input to pytree from Python; let's not have a bunch of low-hanging memory safety issues. ghstack-source-id: 265152272 @exported-using-ghexport Differential Revision: [D68166303](https://our.internmc.facebook.com/intern/diff/D68166303/)
kirklandsign
pushed a commit
that referenced
this pull request
Feb 7, 2025
Pull Request resolved: #7654 It's possible to pass arbitrary string input to pytree from Python; let's not have a bunch of low-hanging memory safety issues. ghstack-source-id: 265152272 @exported-using-ghexport Differential Revision: [D68166303](https://our.internmc.facebook.com/intern/diff/D68166303/) Co-authored-by: Github Executorch <github_executorch@arm.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
It's possible to pass arbitrary string input to pytree from Python; let's not have a bunch of low-hanging memory safety issues.
Differential Revision: D68166303