Skip to content

[ET-VK] Minor fix to conv 2d op using wg_size from create_conv2d_global_wg_size to determine local wg size. #7450

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jan 3, 2025
Merged

[ET-VK] Minor fix to conv 2d op using wg_size from create_conv2d_global_wg_size to determine local wg size. #7450

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
b36e584
[ET-VK] Minor fix to conv 2d op using wg_size from create_conv2d_glob…
trivedivivek Dec 27, 2024
0fb7c98
Update on "[ET-VK] Minor fix to conv 2d op using wg_size from create_…
trivedivivek Jan 2, 2025
269d183
Update on "[ET-VK] Minor fix to conv 2d op using wg_size from create_…
trivedivivek Jan 3, 2025
22f9fb1
Update on "[ET-VK] Minor fix to conv 2d op using wg_size from create_…
trivedivivek Jan 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions backends/vulkan/runtime/graph/ops/impl/Convolution.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -370,11 +370,13 @@ void add_conv2d_node(
weight_data,
clamp_out);

utils::uvec3 wg_size = create_conv2d_global_wg_size(graph, method, out);

graph.execute_nodes().emplace_back(new DispatchNode(
graph,
shader,
create_conv2d_global_wg_size(graph, method, out),
graph.create_local_wg_size(out),
wg_size,
graph.create_local_wg_size(wg_size),
// Inputs and Outputs
{{out, vkapi::MemoryAccessType::WRITE},
{{in, arg_weight, arg_bias}, vkapi::MemoryAccessType::READ}},
Expand Down