[ET-VK] Introduce virtual_transpose() to vTensor for no copy transposition
#5353
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sposition ## Context With `axis_map` integrated into matrix multiplication, we can now test no-copy transposes for texture backed tensors. Transposing a tensor can be done without modifying the storage by swapping elements in the tensor's `axis_map`, and also updating the layout of the tensor if the packed dimension was one of the dims that were transposed. Differential Revision: [D62652009](https://our.internmc.facebook.com/intern/diff/D62652009/) [ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/5353
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit b803bb7 with merge base ef31608 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D62652009 |
This was referenced Sep 13, 2024
SS-JIA
added a commit
that referenced
this pull request
Sep 13, 2024
…sposition ## Context With `axis_map` integrated into matrix multiplication, we can now test no-copy transposes for texture backed tensors. Transposing a tensor can be done without modifying the storage by swapping elements in the tensor's `axis_map`, and also updating the layout of the tensor if the packed dimension was one of the dims that were transposed. Differential Revision: [D62652009](https://our.internmc.facebook.com/intern/diff/D62652009/) ghstack-source-id: 242452080 Pull Request resolved: #5353
jorgep31415
approved these changes
Sep 16, 2024
…o copy transposition" ## Context With `axis_map` integrated into matrix multiplication, we can now test no-copy transposes for texture backed tensors. Transposing a tensor can be done without modifying the storage by swapping elements in the tensor's `axis_map`, and also updating the layout of the tensor if the packed dimension was one of the dims that were transposed. Differential Revision: [D62652009](https://our.internmc.facebook.com/intern/diff/D62652009/) [ghstack-poisoned]
SS-JIA
added a commit
that referenced
this pull request
Sep 16, 2024
…sposition Pull Request resolved: #5353 ## Context With `axis_map` integrated into matrix multiplication, we can now test no-copy transposes for texture backed tensors. Transposing a tensor can be done without modifying the storage by swapping elements in the tensor's `axis_map`, and also updating the layout of the tensor if the packed dimension was one of the dims that were transposed. ghstack-source-id: 242802318 @exported-using-ghexport Differential Revision: [D62652009](https://our.internmc.facebook.com/intern/diff/D62652009/)
|
This pull request was exported from Phabricator. Differential Revision: D62652009 |
|
This pull request has been merged in 26375cc. |
lucylq
pushed a commit
that referenced
this pull request
Sep 17, 2024
#5353) Summary: Pull Request resolved: #5353 ## Context With `axis_map` integrated into matrix multiplication, we can now test no-copy transposes for texture backed tensors. Transposing a tensor can be done without modifying the storage by swapping elements in the tensor's `axis_map`, and also updating the layout of the tensor if the packed dimension was one of the dims that were transposed. ghstack-source-id: 242802318 exported-using-ghexport Reviewed By: jorgep31415 Differential Revision: D62652009 fbshipit-source-id: ae1c81a61a92e69aaa689418d7e62a81d8e09a12
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
virtual_transpose()tovTensorfor no copy transposition #5353Context
With
axis_mapintegrated into matrix multiplication, we can now test no-copy transposes for texture backed tensors.Transposing a tensor can be done without modifying the storage by swapping elements in the tensor's
axis_map, and also updating the layout of the tensor if the packed dimension was one of the dims that were transposed.Differential Revision: D62652009