Skip to content

Add default dim_order asserts #4725

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 16, 2024

Conversation

digantdesai
Copy link
Contributor

Summary:
Add a couple of sanity checks to avoid accepting unsupported dim_order

  • AoT: make sure all the inputs have default dim_order (=contiguous_format)
  • Runtime: all the incoming etensors have default dim_order (=contiguous_format)

Differential Revision: D61311560

Copy link

pytorch-bot bot commented Aug 15, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/4725

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 17c9274 with merge base 9a98abb (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Aug 15, 2024
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D61311560

digantdesai added a commit to digantdesai/executorch-1 that referenced this pull request Aug 15, 2024
Summary:
Pull Request resolved: pytorch#4725

Add a couple of sanity checks to avoid accepting unsupported dim_order

* AoT: make sure all the inputs have default dim_order (=contiguous_format)
* Runtime: all the incoming etensors have default dim_order (=contiguous_format)

Differential Revision: D61311560
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D61311560

Summary:
Pull Request resolved: pytorch#4725

Add a couple of sanity checks to avoid accepting unsupported dim_order

* AoT: make sure all the inputs have default dim_order (=contiguous_format)
* Runtime: all the incoming etensors have default dim_order (=contiguous_format)

Differential Revision: D61311560
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D61311560

@facebook-github-bot facebook-github-bot merged commit b75e7d7 into pytorch:main Aug 16, 2024
34 of 37 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants