[executorch] Clean up MemoryManager API #402
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Remove const allocator, which we don't use - Don't make users create empty allocators for entries they don't use - Pick more-descriptive names Differential Revision: [D49389211](https://our.internmc.facebook.com/intern/diff/D49389211/) [ghstack-poisoned]
facebook-github-bot
added
the
CLA Signed
This was referenced Sep 19, 2023
- Remove const allocator, which we don't use - Don't make users create empty allocators for entries they don't use - Pick more-descriptive names Differential Revision: [D49389211](https://our.internmc.facebook.com/intern/diff/D49389211/) [ghstack-poisoned]
|
This pull request has been merged in 6944c45. |
Gasoonjia
pushed a commit
that referenced
this pull request
Jul 30, 2024
* ET or AOTI backend logic * use args, not builder_args * typo * typo * typo
Gasoonjia
pushed a commit
that referenced
this pull request
Jul 30, 2024
This reverts commit 052fb1a3792123e291fb5f47084644913c8ecba7 to fix [test-tinystories-executorch](https://github.com/pytorch/torchchat/actions/runs/8802811768/job/24159454773?pr=411#logs)
Gasoonjia
pushed a commit
that referenced
this pull request
Jul 30, 2024
Gasoonjia
pushed a commit
that referenced
this pull request
Jul 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
Differential Revision: D49389211