Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add iPad support to demo apps. #3251

Closed
wants to merge 1 commit into from
Closed

Add iPad support to demo apps. #3251

wants to merge 1 commit into from

Conversation

shoumikhin
Copy link
Contributor

Summary: .

Differential Revision: D56488666

@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Apr 23, 2024 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/3251

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure

As of commit f087e3b with merge base 783e932 (image):

NEW FAILURE - The following job has failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Apr 23, 2024
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D56488666

@shoumikhin @facebook-github-bot
Add iPad support to demo apps. (#3251)
f087e3b 
Summary:

.

Differential Revision: D56488666
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D56488666

@facebook-github-bot
Copy link
Contributor

This pull request has been merged in 1eaed2b.

@shoumikhin
Copy link
Contributor Author

shoumikhin commented Apr 23, 2024 •
edited
Loading

@pytorchbot cherry-pick --onto release/0.2 -c regression

@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Apr 23, 2024

❌ 🤖 pytorchbot command failed:

@pytorchbot cherry-pick: error: the following arguments are required: -c/--classification

usage: @pytorchbot cherry-pick --onto ONTO [--fixes FIXES] -c
                               {regression,critical,fixnewfeature,docs,release}

Try @pytorchbot --help for more info.

@shoumikhin
Copy link
Contributor Author

@pytorchbot cherry-pick --onto release/0.2 -c regression

pytorchbot pushed a commit that referenced this pull request Apr 23, 2024
@shoumikhin @pytorchbot
Add iPad support to demo apps. (#3251)
02171cb 
Summary:
Pull Request resolved: #3251

.

Reviewed By: cccclai

Differential Revision: D56488666

fbshipit-source-id: d63a08b4abdf055607948229be88f0c7762948ab
(cherry picked from commit 1eaed2b)
@pytorchbot
Copy link
Collaborator

Cherry picking #3251

The cherry pick PR is at #3256 and it is recommended to link a regression cherry pick PR with an issue

Details for Dev Infra team Raised by workflow job

shoumikhin added a commit that referenced this pull request Apr 24, 2024
@pytorchbot @shoumikhin
Add iPad support to demo apps. (#3251) (#3256)
e783942 
Summary:
Pull Request resolved: #3251

.

Reviewed By: cccclai

Differential Revision: D56488666

fbshipit-source-id: d63a08b4abdf055607948229be88f0c7762948ab
(cherry picked from commit 1eaed2b)

Co-authored-by: Anthony Shoumikhin <shoumikhin@meta.com>
This was referenced Apr 25, 2024
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cccclai cccclai cccclai approved these changes

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported Merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@shoumikhin @facebook-github-bot @pytorchbot @cccclai