Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix llama-runner-linux-android #3127

Closed
wants to merge 1 commit into from

Conversation

manuelcandales
Copy link
Contributor

Differential Revision: D56306284

Copy link

pytorch-bot bot commented Apr 18, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/3127

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 8e8c0c5 with merge base f2e660b (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Apr 18, 2024
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D56306284

manuelcandales added a commit to manuelcandales/executorch-1 that referenced this pull request Apr 18, 2024
Summary: Pull Request resolved: pytorch#3127

Differential Revision: D56306284
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D56306284

@@ -42,6 +42,7 @@ build_llama_runner() {
-DCMAKE_INSTALL_PREFIX=cmake-android-out \
-DCMAKE_BUILD_TYPE=Release -DPYTHON_EXECUTABLE=python \
-DEXECUTORCH_BUILD_OPTIMIZED=ON \
-DEXECUTORCH_BUILD_QUANTIZED=ON \
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry not here

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add it to line 28-29

manuelcandales added a commit to manuelcandales/executorch-1 that referenced this pull request Apr 18, 2024
Summary: Pull Request resolved: pytorch#3127

Reviewed By: larryliu0820, kirklandsign

Differential Revision: D56306284
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D56306284

Summary: Pull Request resolved: pytorch#3127

Reviewed By: larryliu0820, kirklandsign

Differential Revision: D56306284
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D56306284

@facebook-github-bot
Copy link
Contributor

This pull request has been merged in ab02a9c.

@mergennachin mergennachin mentioned this pull request Apr 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported Merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants