Add quantized op support to llama runner #3062
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: Test Plan: Reviewers: Subscribers: Tasks: Tags: [ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/3062
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 New FailureAs of commit 41abbb5 with merge base 458d743 ( NEW FAILURE - The following job has failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
Summary: Test Plan: Reviewers: Subscribers: Tasks: Tags: [ghstack-poisoned]
|
@larryliu0820 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Summary: Test Plan: Reviewers: Subscribers: Tasks: Tags: Differential Revision: [D56197863](https://our.internmc.facebook.com/intern/diff/D56197863) [ghstack-poisoned]
Summary: Test Plan: Reviewers: Subscribers: Tasks: Tags: Differential Revision: [D56197863](https://our.internmc.facebook.com/intern/diff/D56197863) [ghstack-poisoned]
Summary: Test Plan: Reviewers: Subscribers: Tasks: Tags: Differential Revision: [D56197863](https://our.internmc.facebook.com/intern/diff/D56197863) [ghstack-poisoned]
Summary: Test Plan: Reviewers: Subscribers: Tasks: Tags: Differential Revision: [D56197863](https://our.internmc.facebook.com/intern/diff/D56197863) [ghstack-poisoned]
kimishpatel
reviewed
Apr 17, 2024
.ci/scripts/test_llama.sh
Outdated
| @@ -84,7 +91,7 @@ cmake_build_llama_runner() { | |||
| -DEXECUTORCH_BUILD_CUSTOM="$CUSTOM" \ | |||
| -DEXECUTORCH_BUILD_OPTIMIZED=ON \ | |||
| -DEXECUTORCH_BUILD_XNNPACK="$XNNPACK" \ | |||
| -DEXECUTORCH_BUILD_OPTIMIZED=ON \ | |||
| -DEXECUTORCH_BUILD_QUANTIZED="$QE" \ | |||
There was a problem hiding this comment.
Can we not always build? haveing so many options for build feels like additional burden for users. Maybe do default opt-in?
kimishpatel
reviewed
Apr 17, 2024
| EXPORT_ARGS="${EXPORT_ARGS} -kv --use_sdpa_with_kv_cache -X -qmode 8da4w -G 128" | ||
| EXPORT_ARGS="-c stories110M.pt -p ${PARAMS} -d ${DTYPE} -n ${EXPORTED_MODEL_NAME} -kv" | ||
| if [[ "${XNNPACK}" == "ON" ]]; then | ||
| EXPORT_ARGS="${EXPORT_ARGS} -X -qmode 8da4w -G 128" |
There was a problem hiding this comment.
nit: does += operator work?
kimishpatel
reviewed
Apr 17, 2024
kimishpatel
reviewed
Apr 17, 2024
| @@ -91,6 +92,7 @@ add_subdirectory(runner) | |||
| if(EXECUTORCH_USE_TIKTOKEN) | |||
| # find RE2 for tokenizer | |||
| set(ABSL_ENABLE_INSTALL ON) | |||
| set(ABSL_PROPAGATE_CXX_STD ON) | |||
There was a problem hiding this comment.
oh we depend on abseil for tiktoken?
There was a problem hiding this comment.
Yeah, tiktoken -> re2 -> abseil
lucylq
approved these changes
Apr 17, 2024
| @@ -91,6 +92,7 @@ add_subdirectory(runner) | |||
| if(EXECUTORCH_USE_TIKTOKEN) | |||
| # find RE2 for tokenizer | |||
| set(ABSL_ENABLE_INSTALL ON) | |||
| set(ABSL_PROPAGATE_CXX_STD ON) | |||
There was a problem hiding this comment.
no tests using this path yet right?
| EXPORT_ARGS="${EXPORT_ARGS} --use_sdpa_with_kv_cache" | ||
| fi | ||
| if [[ "${QE}" == "ON" ]]; then | ||
| EXPORT_ARGS="${EXPORT_ARGS} --embedding-quantize 8,1024" |
Summary: Test Plan: Reviewers: Subscribers: Tasks: Tags: Differential Revision: [D56197863](https://our.internmc.facebook.com/intern/diff/D56197863) [ghstack-poisoned]
|
@larryliu0820 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
This pull request has been merged in 1f4b631. |
larryliu0820
added a commit
that referenced
this pull request
Apr 18, 2024
Summary: As titled. Got too excited in #3062 and removed `EXECUTORCH_BUILD_QUANTIZED`. Looking at the CI job failure of `build-apple-framework` probably worth adding it back. Test Plan: See that CI job pass Reviewers: Subscribers: Tasks: Tags:
facebook-github-bot
pushed a commit
that referenced
this pull request
Apr 18, 2024
Summary: As titled. Got too excited in #3062 and removed `EXECUTORCH_BUILD_QUANTIZED`. Looking at the CI job failure of `build-apple-framework` probably worth adding it back. Test Plan: See that CI job pass Reviewed By: shoumikhin Differential Revision: D56281923 Pulled By: larryliu0820
facebook-github-bot
pushed a commit
that referenced
this pull request
Apr 18, 2024
Summary: As titled. Got too excited in #3062 and removed `EXECUTORCH_BUILD_QUANTIZED`. Looking at the CI job failure of `build-apple-framework` probably worth adding it back. Pull Request resolved: #3115 Test Plan: See that CI job pass Reviewed By: shoumikhin Differential Revision: D56281923 Pulled By: larryliu0820 fbshipit-source-id: e6ad411f763ff8e11d4fb1e0bc7037eb2cf69357
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
Summary:
Test Plan:
Reviewers:
Subscribers:
Tasks:
Tags:
Differential Revision: D56197863