Skip to content

add export configs #2965

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

add export configs #2965

wants to merge 1 commit into from

Conversation

lucylq
Copy link
Contributor

@lucylq lucylq commented Apr 10, 2024

Differential Revision: D55953027

@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Apr 10, 2024 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/2965

Note: Links to docs will display an error until the docs builds have been completed.

✅ You can merge normally! (1 Unrelated Failure)

As of commit e9abb4d with merge base 62a4dd3 (image):

BROKEN TRUNK - The following job failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Apr 10, 2024
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D55953027

@lucylq lucylq force-pushed the export-D55953027 branch from 76b57d5 to 3fea028 Compare April 11, 2024 19:52
lucylq added a commit to lucylq/executorch-1 that referenced this pull request Apr 11, 2024
@lucylq @facebook-github-bot
add export configs (pytorch#2965)
3fea028 
Summary: Pull Request resolved: pytorch#2965

Differential Revision: D55953027
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D55953027

lucylq added a commit to lucylq/executorch-1 that referenced this pull request Apr 11, 2024
@lucylq @facebook-github-bot
add export configs (pytorch#2965)
e0267cc 
Summary: Pull Request resolved: pytorch#2965

Differential Revision: D55953027
@lucylq lucylq force-pushed the export-D55953027 branch from 3fea028 to e0267cc Compare April 11, 2024 19:52
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D55953027

larryliu0820
larryliu0820 reviewed Apr 11, 2024
View reviewed changes
examples/models/llama2/builder.py
Comment on lines +80 to +82
assert (
checkpoint or checkpoint_dir
) and params_path, "Both checkpoint/checkpoint_dir and params can't be empty"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can't set both of them right?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added a note in the help that checkpoint_dir takes precedence. Think we should keep the defaults in argsparse for now.

examples/models/llama2/llama_transformer.py Outdated
Comment on lines 327 to 328
if args.ffn_dim_multiplier is not None:
hidden_dim = int(args.ffn_dim_multiplier * hidden_dim)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we move this to ModelArgs.post_init() like what torchAt is doing?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated!

lucylq added a commit to lucylq/executorch-1 that referenced this pull request Apr 11, 2024
@lucylq @facebook-github-bot
add export configs (pytorch#2965)
99c897c 
Summary: Pull Request resolved: pytorch#2965

Differential Revision: D55953027
@lucylq lucylq force-pushed the export-D55953027 branch from e0267cc to 99c897c Compare April 11, 2024 20:26
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D55953027

lucylq added a commit to lucylq/executorch-1 that referenced this pull request Apr 11, 2024
@lucylq @facebook-github-bot
add export configs (pytorch#2965)
bee3525 
Summary: Pull Request resolved: pytorch#2965

Differential Revision: D55953027
@lucylq lucylq force-pushed the export-D55953027 branch from 99c897c to bee3525 Compare April 11, 2024 20:27
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D55953027

@lucylq @facebook-github-bot
add export configs (pytorch#2965)
e9abb4d 
Summary: Pull Request resolved: pytorch#2965

Differential Revision: D55953027
@lucylq lucylq force-pushed the export-D55953027 branch from bee3525 to e9abb4d Compare April 11, 2024 20:53
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D55953027

larryliu0820
larryliu0820 approved these changes Apr 12, 2024
View reviewed changes
Copy link
Contributor

@larryliu0820 larryliu0820 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@facebook-github-bot
Copy link
Contributor

This pull request has been merged in ab323a5.

@mergennachin mergennachin mentioned this pull request Apr 26, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@larryliu0820 larryliu0820 larryliu0820 approved these changes

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported Merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lucylq @facebook-github-bot @larryliu0820