-
Notifications
You must be signed in to change notification settings - Fork 607
resolve_buck.py: Add an entry for darwin-x86_64 #2868
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/2868
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 011d5c0 with merge base 92b5cfc ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
I'm away from my work machine til next week so I won't be able to land this myself until then, so please clone/commandeer this PR if you think it'll be useful. |
Thanks for grabbing the version hash! I'm intending to land this and then cherry-pick onto 0.2. Should alleviate potential pain for Intel mac users, since we removed the buck download information (perhaps prematurely?). |
@GregoryComer has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
@pytorchbot cherry-pick --onto release/0.2 -c critical |
@GregoryComer merged this pull request in de7fdaa. |
Trying again, since it seems like it didn't work. Maybe because I triggered the cherry-pick before the bot registered that it landed? @pytorchbot cherry-pick --onto release/0.2 -c critical |
Summary: Version hash reported by https://github.com/facebook/buck2/releases/download/2024-02-15/buck2-x86_64-apple-darwin.zst Pull Request resolved: #2868 Reviewed By: Olivia-liu Differential Revision: D55914146 Pulled By: GregoryComer fbshipit-source-id: b9882900acfd4cb6f74eda90a7c99bdb119ec122 (cherry picked from commit de7fdaa)
Cherry picking #2868The cherry pick PR is at #2960 and it is recommended to link a critical cherry pick PR with an issue Details for Dev Infra teamRaised by workflow job |
Summary: Version hash reported by https://github.com/facebook/buck2/releases/download/2024-02-15/buck2-x86_64-apple-darwin.zst Pull Request resolved: #2868 Reviewed By: Olivia-liu Differential Revision: D55914146 Pulled By: GregoryComer fbshipit-source-id: b9882900acfd4cb6f74eda90a7c99bdb119ec122 (cherry picked from commit de7fdaa)
Version hash reported by
https://github.com/facebook/buck2/releases/download/2024-02-15/buck2-x86_64-apple-darwin.zst