Allow each model to choose its own runner #277
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
@huydhn has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
facebook-github-bot
pushed a commit
that referenced
this pull request
Sep 13, 2023
Summary: I mistakenly replace this in #277. The runner is not set here, and causes syntax error, for example https://github.com/pytorch/executorch/actions/runs/6167285165. The workflow still works because the default `linux.2xlarge` is used (same runner type) ### Testing The annotation error is gone now https://github.com/pytorch/executorch/actions/runs/6175961826 Pull Request resolved: #313 Test Plan: https://github.com/pytorch/executorch/actions/runs/6175961826 Reviewed By: mergennachin Differential Revision: D49236002 Pulled By: huydhn fbshipit-source-id: bd5282f582d23427fd1d7622ed3b2ee2e6ad93cb
Gasoonjia
pushed a commit
that referenced
this pull request
Jul 30, 2024
Add special case for zero-temperature sampling. For stories15M on my devserver, seems to improve tokens/sec as follows: before: 189, 180, 166 after: 264, 285, 285
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's a good idea to allow each model to choose its own runner. This also help unblock #212 until we know the root cause of why it runs OOM.