(Partial) Bug fix for test_xnnpack_dq4_kv_fp32_llama #2691
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/2691
Note: Links to docs will display an error until the docs builds have been completed. ❗ 1 Active SEVsThere are 1 currently active SEVs. If your PR is affected, please view them below: ❌ 1 New FailureAs of commit 564ca2c with merge base 253f2fa ( NEW FAILURE - The following job has failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D55373341 |
mergennachin
approved these changes
Mar 26, 2024
Summary: (Partial) Bug fix for test_xnnpack_dq4_kv_fp32_llama Also: reduce/comment out debug messages for release This fixes an ancillary bug, but does not address the xnnpack registration error 20. Reviewed By: mergennachin, JacobSzwejbka Differential Revision: D55373341
mikekgfb
force-pushed
the
export-D55373341
branch
from
c2a6d0d to
564ca2c
Compare
|
This pull request was exported from Phabricator. Differential Revision: D55373341 |
|
This pull request has been merged in 3095d09. |
mergennachin
added a commit
to mergennachin/executorch-1
that referenced
this pull request
Mar 27, 2024
Summary: When pytorch#2691 landed, it commented out bunch of print lines, which triggered a lint warning (unused variable). https://github.com/pytorch/executorch/actions/runs/8444809723/job/23131006488 Reviewed By: guangy10 Differential Revision: D55402192
mergennachin
added a commit
to mergennachin/executorch-1
that referenced
this pull request
Mar 27, 2024
Summary: When pytorch#2691 landed, it commented out bunch of print lines, which triggered a lint warning (unused variable). https://github.com/pytorch/executorch/actions/runs/8444809723/job/23131006488 Reviewed By: guangy10 Differential Revision: D55402192
mergennachin
added a commit
to mergennachin/executorch-1
that referenced
this pull request
Mar 27, 2024
Summary: When pytorch#2691 landed, it commented out bunch of print lines, which triggered a lint warning (unused variable). Pull Request resolved: pytorch#2701 https://github.com/pytorch/executorch/actions/runs/8444809723/job/23131006488 Reviewed By: guangy10 Differential Revision: D55402192
facebook-github-bot
pushed a commit
that referenced
this pull request
Mar 27, 2024
Summary: When #2691 landed, it commented out bunch of print lines, which triggered a lint warning (unused variable). Pull Request resolved: #2701 https://github.com/pytorch/executorch/actions/runs/8444809723/job/23131006488 Reviewed By: guangy10 Differential Revision: D55402192 fbshipit-source-id: 903a905dc9270a1eae6e1125f9110ead37e6d811
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
(Partial) Bug fix for test_xnnpack_dq4_kv_fp32_llama
Also: reduce/comment out debug messages for release
This fixes an ancillary bug, but does not address the xnnpack registration error 20.
Reviewed By: JacobSzwejbka
Differential Revision: D55373341