Skip to content

Refactor XNN workspace sharing to allow runtime gating #11748

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

GregoryComer
Copy link
Member

@GregoryComer GregoryComer commented Jun 17, 2025

Summary

Refactor the XNN backend workspace sharing logic to allow runtime gating. I've also added a temporary (marked experimental) API to enable workspace sharing. This will be replaced with backend options once available.

Test plan

CI

Copy link

pytorch-bot bot commented Jun 17, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/11748

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure

As of commit af3e5b7 with merge base 7503bb3 (image):

NEW FAILURE - The following job has failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jun 17, 2025
@GregoryComer GregoryComer force-pushed the xnnpack-runtime-workspace-sharing branch 2 times, most recently from f12f1ff to 0fd2a34 Compare June 17, 2025 03:44
@GregoryComer GregoryComer added the release notes: none Do not include this in the release notes label Jun 17, 2025
@facebook-github-bot
Copy link
Contributor

@GregoryComer has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@GregoryComer GregoryComer force-pushed the xnnpack-runtime-workspace-sharing branch 3 times, most recently from 3ed0e10 to 3c08efe Compare June 17, 2025 05:45
@facebook-github-bot
Copy link
Contributor

@GregoryComer has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

…#11748)

Summary:
Refactor the XNN backend workspace sharing logic to allow runtime gating. I've also added a temporary (marked experimental) API to enable workspace sharing. This will be replaced with backend options once available.

Pull Request resolved: pytorch#11748

Test Plan:
CI

Rollback Plan:

Differential Revision: D76789804

Pulled By: GregoryComer
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D76789804

@GregoryComer GregoryComer force-pushed the xnnpack-runtime-workspace-sharing branch from 3c08efe to af3e5b7 Compare June 17, 2025 20:36
@GregoryComer GregoryComer changed the title (WIP) Refactor XNN workspace sharing to allow runtime gating Refactor XNN workspace sharing to allow runtime gating Jun 17, 2025
@GregoryComer GregoryComer marked this pull request as ready for review June 17, 2025 20:37
@mergennachin mergennachin requested a review from cccclai June 18, 2025 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported release notes: none Do not include this in the release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants