Skip to content

Export a lora model #11045

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: gh/lucylq/83/base
Choose a base branch
from
Open

Export a lora model #11045

wants to merge 1 commit into from

Conversation

lucylq
Copy link
Contributor

@lucylq lucylq commented May 21, 2025

Stack from ghstack (oldest at bottom):

^

Program+data combined currently, using the lora linear definition.

Differential Revision: D75153377

^

Program+data combined currently, using the lora linear definition.

Differential Revision: [D75153377](https://our.internmc.facebook.com/intern/diff/D75153377/)

[ghstack-poisoned]
Copy link

pytorch-bot bot commented May 21, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/11045

Note: Links to docs will display an error until the docs builds have been completed.

❌ 5 New Failures

As of commit aac7fd6 with merge base 6a8d286 (image):

NEW FAILURES - The following jobs have failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

lucylq added a commit that referenced this pull request May 21, 2025
^

Program+data combined currently, using the lora linear definition.

Differential Revision: [D75153377](https://our.internmc.facebook.com/intern/diff/D75153377/)

ghstack-source-id: 285402970
Pull Request resolved: #11045
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label May 21, 2025
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D75153377

@lucylq lucylq added the release notes: llm To capture llm specific changes in release notes label May 21, 2025
adapter_checkpoint = {}
adapter_config = {}
adapter_checkpoint_path = kwargs.get("adapter_checkpoint", None)
if adapter_checkpoint_path:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: use os.exists or similar from Path?

Copy link
Contributor

@digantdesai digantdesai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tests?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported release notes: llm To capture llm specific changes in release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants