Dtype selective build: enable in fbcode #11016
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
^ By removing `header_namespace` and depending on #include "selected_op_variants.h" instead of the full path #include <executorch/kernels/portable/cpu/selected_op_variants.h> Note: expose_operator_symbols=False only works in xplat, so add a failure message for that too. I don't think we should recommend for users to set it to true, as it prevents a library from linking multiple executorch_generated_libs (symbols will clash). Differential Revision: [D75082395](https://our.internmc.facebook.com/intern/diff/D75082395/) [ghstack-poisoned]
This was referenced May 20, 2025
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/11016
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 9a72503 with merge base 5268b24 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
lucylq
added a commit
that referenced
this pull request
May 20, 2025
^ By removing `header_namespace` and depending on #include "selected_op_variants.h" instead of the full path #include <executorch/kernels/portable/cpu/selected_op_variants.h> Note: expose_operator_symbols=False only works in xplat, so add a failure message for that too. I don't think we should recommend for users to set it to true, as it prevents a library from linking multiple executorch_generated_libs (symbols will clash). Differential Revision: [D75082395](https://our.internmc.facebook.com/intern/diff/D75082395/) ghstack-source-id: 285203336 Pull Request resolved: #11016
|
This pull request was exported from Phabricator. Differential Revision: D75082395 |
^ By removing `header_namespace` and depending on #include "selected_op_variants.h" instead of the full path #include <executorch/kernels/portable/cpu/selected_op_variants.h> Note: expose_operator_symbols=False only works in xplat, so add a failure message for that too. I don't think we should recommend for users to set it to true, as it prevents a library from linking multiple executorch_generated_libs (symbols will clash). Differential Revision: [D75082395](https://our.internmc.facebook.com/intern/diff/D75082395/) [ghstack-poisoned]
lucylq
added a commit
that referenced
this pull request
May 20, 2025
Pull Request resolved: #11016 ^ By removing `header_namespace` and depending on #include "selected_op_variants.h" instead of the full path #include <executorch/kernels/portable/cpu/selected_op_variants.h> Note: expose_operator_symbols=False only works in xplat, so add a failure message for that too. I don't think we should recommend for users to set it to true, as it prevents a library from linking multiple executorch_generated_libs (symbols will clash). Differential Revision: [D75082395](https://our.internmc.facebook.com/intern/diff/D75082395/) ghstack-source-id: 285224490
|
This pull request was exported from Phabricator. Differential Revision: D75082395 |
larryliu0820
approved these changes
May 20, 2025
^ By removing `header_namespace` and depending on #include "selected_op_variants.h" instead of the full path #include <executorch/kernels/portable/cpu/selected_op_variants.h> Note: expose_operator_symbols=False only works in xplat, so add a failure message for that too. I don't think we should recommend for users to set it to true, as it prevents a library from linking multiple executorch_generated_libs (symbols will clash). Differential Revision: [D75082395](https://our.internmc.facebook.com/intern/diff/D75082395/) [ghstack-poisoned]
lucylq
added a commit
that referenced
this pull request
May 22, 2025
Pull Request resolved: #11016 ^ By removing `header_namespace` and depending on #include "selected_op_variants.h" instead of the full path #include <executorch/kernels/portable/cpu/selected_op_variants.h> Note: expose_operator_symbols=False only works in xplat, so add a failure message for that too. I don't think we should recommend for users to set it to true, as it prevents a library from linking multiple executorch_generated_libs (symbols will clash). ghstack-source-id: 285662532 Differential Revision: [D75082395](https://our.internmc.facebook.com/intern/diff/D75082395/)
|
This pull request was exported from Phabricator. Differential Revision: D75082395 |
^ By removing `header_namespace` and depending on #include "selected_op_variants.h" instead of the full path #include <executorch/kernels/portable/cpu/selected_op_variants.h> Note: expose_operator_symbols=False only works in xplat, so add a failure message for that too. I don't think we should recommend for users to set it to true, as it prevents a library from linking multiple executorch_generated_libs (symbols will clash). Differential Revision: [D75082395](https://our.internmc.facebook.com/intern/diff/D75082395/) [ghstack-poisoned]
lucylq
added a commit
that referenced
this pull request
May 22, 2025
Pull Request resolved: #11016 ^ By removing `header_namespace` and depending on #include "selected_op_variants.h" instead of the full path #include <executorch/kernels/portable/cpu/selected_op_variants.h> Note: expose_operator_symbols=False only works in xplat, so add a failure message for that too. I don't think we should recommend for users to set it to true, as it prevents a library from linking multiple executorch_generated_libs (symbols will clash). ghstack-source-id: 285663028 Differential Revision: [D75082395](https://our.internmc.facebook.com/intern/diff/D75082395/)
|
This pull request was exported from Phabricator. Differential Revision: D75082395 |
^ By removing `header_namespace` and depending on #include "selected_op_variants.h" instead of the full path #include <executorch/kernels/portable/cpu/selected_op_variants.h> Note: expose_operator_symbols=False only works in xplat, so add a failure message for that too. I don't think we should recommend for users to set it to true, as it prevents a library from linking multiple executorch_generated_libs (symbols will clash). Differential Revision: [D75082395](https://our.internmc.facebook.com/intern/diff/D75082395/) [ghstack-poisoned]
lucylq
added a commit
that referenced
this pull request
May 22, 2025
Pull Request resolved: #11016 ^ By removing `header_namespace` and depending on #include "selected_op_variants.h" instead of the full path #include <executorch/kernels/portable/cpu/selected_op_variants.h> Note: expose_operator_symbols=False only works in xplat, so add a failure message for that too. I don't think we should recommend for users to set it to true, as it prevents a library from linking multiple executorch_generated_libs (symbols will clash). ghstack-source-id: 285663278 Differential Revision: [D75082395](https://our.internmc.facebook.com/intern/diff/D75082395/)
|
This pull request was exported from Phabricator. Differential Revision: D75082395 |
facebook-github-bot
merged commit 3046c3b
into
gh/lucylq/81/base
89 of 90 checks passed
facebook-github-bot
temporarily deployed
to
cherry-pick-bot
GitHub Actions
Inactive
kirklandsign
pushed a commit
that referenced
this pull request
May 23, 2025
Pull Request resolved: #11016 ^ By removing `header_namespace` and depending on #include "selected_op_variants.h" instead of the full path #include <executorch/kernels/portable/cpu/selected_op_variants.h> Note: expose_operator_symbols=False only works in xplat, so add a failure message for that too. I don't think we should recommend for users to set it to true, as it prevents a library from linking multiple executorch_generated_libs (symbols will clash). ghstack-source-id: 285663278 Differential Revision: [D75082395](https://our.internmc.facebook.com/intern/diff/D75082395/)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
^
By removing
header_namespaceand depending on #include "selected_op_variants.h" instead of the full path #include <executorch/kernels/portable/cpu/selected_op_variants.h>Note:
expose_operator_symbols=False only works in xplat, so add a failure message for that too. I don't think we should recommend for users to set it to true, as it prevents a library from linking multiple executorch_generated_libs (symbols will clash).
Differential Revision: D75082395