Dtype selective build: check if portable/optimized in deps #10998
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When dtype selective build is enabled: Show a warning if kernel_deps does not contain portable/optimized Error out if deps contains portable/optimized, and it is also in kernel_deps. Differential Revision: [D74922471](https://our.internmc.facebook.com/intern/diff/D74922471/) [ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/10998
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit ecd1cb7 with merge base d50f26f ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
lucylq
added a commit
that referenced
this pull request
May 20, 2025
When dtype selective build is enabled: Show a warning if kernel_deps does not contain portable/optimized Error out if deps contains portable/optimized, and it is also in kernel_deps. Differential Revision: [D74922471](https://our.internmc.facebook.com/intern/diff/D74922471/) ghstack-source-id: 285013949 Pull Request resolved: #10998
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D74922471 |
When dtype selective build is enabled: Show a warning if kernel_deps does not contain portable/optimized Error out if deps contains portable/optimized, and it is also in kernel_deps. Differential Revision: [D74922471](https://our.internmc.facebook.com/intern/diff/D74922471/) [ghstack-poisoned]
|
This pull request was exported from Phabricator. Differential Revision: D74922471 |
larryliu0820
approved these changes
May 20, 2025
facebook-github-bot
merged commit 6065894
into
gh/lucylq/80/base
168 of 170 checks passed
facebook-github-bot
temporarily deployed
to
cherry-pick-bot
GitHub Actions
Inactive
kirklandsign
pushed a commit
that referenced
this pull request
May 21, 2025
Pull Request resolved: #10998 When dtype selective build is enabled, error out if `kernel_deps` contains portable/optimized ops, and `deps` also contains portable/optimized. The check is recursive, ie, if any item in `deps` transitively depends on portable/optimized. Differential Revision: [D74922471](https://our.internmc.facebook.com/intern/diff/D74922471/) ghstack-source-id: 285201954
kirklandsign
pushed a commit
that referenced
this pull request
May 21, 2025
Pull Request resolved: #10998 When dtype selective build is enabled, error out if `kernel_deps` contains portable/optimized ops, and `deps` also contains portable/optimized. The check is recursive, ie, if any item in `deps` transitively depends on portable/optimized. Differential Revision: [D74922471](https://our.internmc.facebook.com/intern/diff/D74922471/) ghstack-source-id: 285201954
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
When dtype selective build is enabled:
Show a warning if kernel_deps does not contain portable/optimized
Error out if deps contains portable/optimized, and it is also in kernel_deps.
Differential Revision: D74922471