Skip to content

Dtype selective build: fail if not xplat, if portable/optimized not in kernel_deps #10988

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Dtype selective build: fail if not xplat, if portable/optimized not in kernel_deps #10988

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions shim_et/xplat/executorch/codegen/codegen.bzl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -641,6 +641,20 @@ def executorch_generated_lib(
if not aten_mode and not functions_yaml_target and not custom_ops_yaml_target:
fail("At least one of functions_yaml_target, custom_ops_yaml_target needs to be provided")

if dtype_selective_build:
if not is_xplat():
warning("WARNING: dtype_selective_build is only available in xplat. Proceeding without dtype selective build for lib: {}.".format(name))

# Dtype selective build is enabled on portable and optimized kernel libraries.
if (not "//executorch/kernels/portable:operators" in kernel_deps) and (not "//executorch/kernels/optimized:optimized_operators" in kernel_deps):
fail("""Dtype_selective_build is enabled and kernel_deps does not contain portable or optimized dependencies.
Please add one of these to kernel_deps:
//executorch/kernels/portable:operators
//executorch/kernels/optimized:optimized_operators
This will tell the build system to rebuild portable/optimized with dtype selective build enabled.
Currently, kernel_deps contains {}.
""".format(kernel_deps))

aten_suffix = "_aten" if aten_mode else ""

# merge functions.yaml with fallback yaml
Expand Down
Loading