Qualcomm AI Engine Direct - Support tile op for different I/O rank #10054
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/10054
Note: Links to docs will display an error until the docs builds have been completed. ❌ 2 New FailuresAs of commit a825fd1 with merge base c9c5481 ( NEW FAILURES - The following jobs have failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
|
@pytorchbot label "release notes: qualcomm" |
pytorch-bot
bot
added
the
release notes: qualcomm
cccclai
approved these changes
Apr 10, 2025
|
@cccclai has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
I encountered this issue while enabling the image encoder of the LLaVA model. |
|
@cccclai , I'd like to refine this PR a bit. Could you please wait for me to update this PR before merging? |
Summary: - Support if the rank of input tensor is less than the rank of output tensor. - make_quantizer kwargs alignment. - Remove module.eval() since calling eval() is not supported for exported models.
DannyYuyang-quic
force-pushed
the
dev1/danny/support_tile_op_with_diff_IO_rank
branch
from
fc5c30b to
a825fd1
Compare
Done, an equivalent approach but more concise. |
|
@cccclai has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
manuelcandales
added a commit
to manuelcandales/executorch-1
that referenced
this pull request
Apr 11, 2025
Summary: forward fix for pytorch#10054 Differential Revision: D72834413
Closed
cccclai
added a commit
that referenced
this pull request
Apr 11, 2025
Fix the lint error from #10054
kirklandsign
pushed a commit
that referenced
this pull request
Apr 11, 2025
…10054) Summary: - Support if the rank of input tensor is less than the rank of output tensor. - make_quantizer kwargs alignment. - Remove module.eval() since calling eval() is not supported for exported models. ### Test plan ``` bash python -m backends.qualcomm.tests.test_qnn_delegate TestQNNQuantizedOperator.test_qnn_backend_expand -s ${device_id} -H ${host_id} -m ${soc} -b build-android ```
kirklandsign
pushed a commit
that referenced
this pull request
Apr 11, 2025
Fix the lint error from #10054
keyprocedure
pushed a commit
to keyprocedure/executorch
that referenced
this pull request
Apr 21, 2025
…ytorch#10054) Summary: - Support if the rank of input tensor is less than the rank of output tensor. - make_quantizer kwargs alignment. - Remove module.eval() since calling eval() is not supported for exported models. ### Test plan ``` bash python -m backends.qualcomm.tests.test_qnn_delegate TestQNNQuantizedOperator.test_qnn_backend_expand -s ${device_id} -H ${host_id} -m ${soc} -b build-android ```
keyprocedure
pushed a commit
to keyprocedure/executorch
that referenced
this pull request
Apr 21, 2025
Fix the lint error from pytorch#10054
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Test plan