Remove Functions.h/cpp (#2245)

Summary:
bypass-github-export-checks

Pull Request resolved: #2245

In D53982443, OperatorRegistry.h/cpp and Functions.h/cpp were both introduced, as they were split across the PT and ET repos, but now both are in ET.

## OperatorRegistry.cpp
Here, we see all our operators. OPERATOR_ENTRY maps from Vulkan Dialect op name to the OpFunction, which have an op-specific name. Note that all OpFunction carry the same function signature.

## Functions.h/cpp -> Arithmetic.h/cpp
We don't need another place to see all our operators. They will each reference one ops/impl file, so we group them accordingly in their ops/impl file.

## Nit
Also, sort `add_arithmetic_node()` declarations according to their execution order.
ghstack-source-id: 217394062
exported-using-ghexport

Reviewed By: SS-JIA

Differential Revision: D54370467

fbshipit-source-id: d9e82896577610d5dcee3e0bf7f662e69d59e1db

Author: jorgep31415

backends/vulkan/runtime/graph/ops/Functions.cpp

@@ -8,7 +8,7 @@
 
 #include <executorch/backends/vulkan/runtime/graph/ops/OperatorRegistry.h>
 
-#include <executorch/backends/vulkan/runtime/graph/ops/Functions.h>
+#include <executorch/backends/vulkan/runtime/graph/ops/impl/Arithmetic.h>
 
 namespace at {
 namespace native {

backends/vulkan/runtime/graph/ops/OperatorRegistry.cpp

@@ -10,21 +10,16 @@
 
 #ifdef USE_VULKAN_API
 
+#include <ATen/native/vulkan/impl/Arithmetic.h>
+
 #include <executorch/backends/vulkan/runtime/graph/ComputeGraph.h>
 
 namespace at {
 namespace native {
 namespace vulkan {
 
-#define DEFINE_OP_FN(name) \
-  ValueRef name(ComputeGraph& graph, const std::vector<ValueRef>& args);
-
-DEFINE_OP_FN(add);
-DEFINE_OP_FN(sub);
-DEFINE_OP_FN(mul);
-DEFINE_OP_FN(div);
-DEFINE_OP_FN(floor_div);
-DEFINE_OP_FN(pow);
+#define DECLARE_OP_FN(function) \
+  ValueRef function(ComputeGraph& graph, const std::vector<ValueRef>& args);
 
 } // namespace vulkan
 } // namespace native

backends/vulkan/runtime/graph/ops/Functions.h renamed to backends/vulkan/runtime/graph/ops/Utils.h

@@ -16,6 +16,39 @@ namespace at {
 namespace native {
 namespace vulkan {
 
+#define DEFINE_ARITHMETIC_FN(function, op_type)                               \
+  ValueRef function(ComputeGraph& graph, const std::vector<ValueRef>& args) { \
+    return add_arithmetic_node(                                               \
+        graph,                                                                \
+        args[0],                                                              \
+        args[1],                                                              \
+        args[2],                                                              \
+        arithmetic::OpType::op_type,                                          \
+        args[3]);                                                             \
+  }
+
+DEFINE_ARITHMETIC_FN(add, ADD);
+DEFINE_ARITHMETIC_FN(sub, SUB);
+DEFINE_ARITHMETIC_FN(mul, MUL);
+DEFINE_ARITHMETIC_FN(div, DIV);
+DEFINE_ARITHMETIC_FN(floor_div, FLOOR_DIV);
+DEFINE_ARITHMETIC_FN(pow, POW);
+
+ValueRef add_arithmetic_node(
+    ComputeGraph& graph,
+    const ValueRef t1,
+    const ValueRef t2,
+    const float alpha,
+    const arithmetic::OpType optype,
+    const int64_t shared_object_idx) {
+  std::vector<int64_t> t1_sizes = graph.get_val_sizes(t1);
+  api::ScalarType t1_dtype = graph.get_val_dtype(t1);
+
+  ValueRef out = graph.add_tensor(t1_sizes, t1_dtype, shared_object_idx);
+  add_arithmetic_node(graph, t1, t2, out, alpha, optype);
+  return out;
+}
+
 void add_arithmetic_node(
     ComputeGraph& graph,
     const ValueRef t1,
@@ -46,21 +79,6 @@ void add_arithmetic_node(
       new ArithmeticNode(arg1, arg2, out, alpha, optype));
 }
 
-ValueRef add_arithmetic_node(
-    ComputeGraph& graph,
-    const ValueRef t1,
-    const ValueRef t2,
-    const float alpha,
-    const arithmetic::OpType optype,
-    const int64_t shared_object_idx) {
-  std::vector<int64_t> t1_sizes = graph.get_val_sizes(t1);
-  api::ScalarType t1_dtype = graph.get_val_dtype(t1);
-
-  ValueRef out = graph.add_tensor(t1_sizes, t1_dtype, shared_object_idx);
-  add_arithmetic_node(graph, t1, t2, out, alpha, optype);
-  return out;
-}
-
 ArithmeticPrepack::ArithmeticPrepack(const ValueRef tref, const ValueRef packed)
     : PrepackNode(tref, packed) {}
 

backends/vulkan/runtime/graph/ops/impl/Arithmetic.cpp

@@ -14,25 +14,34 @@
 
 #include <executorch/backends/vulkan/runtime/graph/ComputeGraph.h>
 
+#include <executorch/backends/vulkan/runtime/graph/ops/Utils.h>
+
 namespace at {
 namespace native {
 namespace vulkan {
 
-void add_arithmetic_node(
+DECLARE_OP_FN(add);
+DECLARE_OP_FN(sub);
+DECLARE_OP_FN(mul);
+DECLARE_OP_FN(div);
+DECLARE_OP_FN(floor_div);
+DECLARE_OP_FN(pow);
+
+ValueRef add_arithmetic_node(
     ComputeGraph& graph,
     const ValueRef t1,
     const ValueRef t2,
-    const ValueRef out,
     const float alpha,
-    const arithmetic::OpType optype);
+    const arithmetic::OpType optype,
+    const int64_t shared_object_idx = -1);
 
-ValueRef add_arithmetic_node(
+void add_arithmetic_node(
     ComputeGraph& graph,
     const ValueRef t1,
     const ValueRef t2,
+    const ValueRef out,
     const float alpha,
-    const arithmetic::OpType optype,
-    const int64_t shared_object_idx = -1);
+    const arithmetic::OpType optype);
 
 class ArithmeticPrepack : public virtual PrepackNode {
  public: