Skip to content

Commit deb3cd1

Browse files
authored
Don't repeatedly find_package(GTest) while running CMake (#9146)
This seems to improve cmake times by 6-10 seconds on my machine.
1 parent 9dcee22 commit deb3cd1

File tree

1 file changed

+8
-2
lines changed

1 file changed

+8
-2
lines changed

build/Test.cmake

Lines changed: 8 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -35,8 +35,14 @@ function(et_cxx_test target_name)
3535
set(multi_arg_names SOURCES EXTRA_LIBS)
3636
cmake_parse_arguments(ET_CXX_TEST "" "" "${multi_arg_names}" ${ARGN})
3737

38-
add_executable(${target_name} ${ET_CXX_TEST_SOURCES} ${EXECUTORCH_ROOT}/runtime/core/exec_aten/testing_util/tensor_util.cpp)
39-
find_package(GTest)
38+
add_executable(
39+
${target_name}
40+
${ET_CXX_TEST_SOURCES}
41+
${EXECUTORCH_ROOT}/runtime/core/exec_aten/testing_util/tensor_util.cpp
42+
)
43+
if(NOT TARGET GTest::gtest)
44+
find_package(GTest)
45+
endif()
4046
# Includes gtest, gmock, executorch by default
4147
target_link_libraries(
4248
${target_name} GTest::gtest GTest::gtest_main GTest::gmock executorch

0 commit comments

Comments
 (0)