Skip to content

Commit ac4dddb

Browse files
committed
Fix typo
1 parent 9f6be16 commit ac4dddb

File tree

3 files changed

+6
-3
lines changed

3 files changed

+6
-3
lines changed

.github/workflows/pull.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -76,7 +76,7 @@ jobs:
7676
conda activate "${CONDA_ENV}"
7777
# Debug
7878
which pip
79-
PYTHON_EXECUTABLE=python bash ./install_executorch.sh --editable-mode --pybind xnnpack --use-pt-pinned-commit
79+
PYTHON_EXECUTABLE=python bash ./install_executorch.sh --editable --pybind xnnpack --use-pt-pinned-commit
8080
# Try to import extension library
8181
python -c "from executorch.extension.llm.custom_ops import custom_ops"
8282

.github/workflows/trunk.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -57,7 +57,7 @@ jobs:
5757
# Debug
5858
which pip
5959
bash .ci/scripts/setup-conda.sh
60-
PYTHON_EXECUTABLE=python ${CONDA_RUN} bash ./install_executorch.sh --editable-mode --pybind xnnpack --use-pt-pinned-commit
60+
PYTHON_EXECUTABLE=python ${CONDA_RUN} bash ./install_executorch.sh --editable --pybind xnnpack --use-pt-pinned-commit
6161
# Try to import extension library
6262
python -c "from executorch.extension.llm.custom_ops import custom_ops"
6363

install_executorch.py

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -65,6 +65,7 @@ def clean():
6565
"prelude": "BUCK",
6666
"pthreadpool": "CMakeLists.txt",
6767
"pybind11": "CMakeLists.txt",
68+
"shim": "BUCK",
6869
"XNNPACK": "CMakeLists.txt",
6970
}
7071

@@ -234,7 +235,9 @@ def main(args):
234235
"-m",
235236
"pip",
236237
"install",
237-
"-e" if args.editable_mode else "",
238+
]
239+
+ (["--editable"] if args.editable else [])
240+
+ [
238241
".",
239242
"--no-build-isolation",
240243
"-v",

0 commit comments

Comments
 (0)