File tree 2 files changed +3
-4
lines changed
shim_et/xplat/executorch/codegen 2 files changed +3
-4
lines changed Original file line number Diff line number Diff line change @@ -65,7 +65,7 @@ def define_common_targets():
65
65
deps = [
66
66
":select_ops_in_dict" ,
67
67
],
68
- dtype_selective_build = True ,
68
+ dtype_selective_build = is_xplat () ,
69
69
visibility = ["//executorch/..." ],
70
70
)
71
71
@@ -78,7 +78,7 @@ def define_common_targets():
78
78
deps = [
79
79
":select_ops_in_dict" ,
80
80
],
81
- dtype_selective_build = True ,
81
+ dtype_selective_build = is_xplat () ,
82
82
visibility = ["//executorch/..." ],
83
83
)
84
84
Original file line number Diff line number Diff line change @@ -644,8 +644,7 @@ def executorch_generated_lib(
644
644
645
645
if dtype_selective_build :
646
646
if not expose_operator_symbols and not is_xplat ():
647
- # TODO(T225169282): make this a fail once internal cases move to xplat.
648
- warning ("""
647
+ fail ("""
649
648
Dtype selective build with expose_operator_symbols=False works only in xplat -
650
649
there are undefined symbols otherwise. Please try to use xplat, or talk to the
651
650
executorch team. Setting expose_operator_symbols=True is not recommended as the
You can’t perform that action at this time.
0 commit comments