No need to expose executorch dependency executorch_core

kirklandsign · web-flow · commit 578358b78e58 · 2025-05-05T10:54:02.000-07:00
Differential Revision: D74184926 Pull Request resolved: #10673
diff --git a/CMakeLists.txt b/CMakeLists.txt
@@ -608,7 +608,7 @@ endif()
 # any backends.
 #
 add_library(executorch ${_executorch__srcs})
-target_link_libraries(executorch PUBLIC executorch_core)
+target_link_libraries(executorch PRIVATE executorch_core)
 target_include_directories(executorch PUBLIC ${_common_include_directories})
 target_compile_definitions(executorch PUBLIC C10_USING_CUSTOM_GENERATED_MACROS)
 target_compile_options(executorch PUBLIC ${_common_compile_options})

Original file line number	Diff line number	Diff line change
`@@ -608,7 +608,7 @@ endif()`
`608`	`608`	`# any backends.`
`609`	`609`	`#`
`610`	`610`	`add_library(executorch ${_executorch__srcs})`
`611`		`-target_link_libraries(executorch PUBLIC executorch_core)`
	`611`	`+target_link_libraries(executorch PRIVATE executorch_core)`
`612`	`612`	`target_include_directories(executorch PUBLIC ${_common_include_directories})`
`613`	`613`	`target_compile_definitions(executorch PUBLIC C10_USING_CUSTOM_GENERATED_MACROS)`
`614`	`614`	`target_compile_options(executorch PUBLIC ${_common_compile_options})`