Skip to content

Commit 2552c0b

Browse files
committed
Update on "Dtype selective build: enable in fbcode"
^ By removing `header_namespace` and depending on #include "selected_op_variants.h" instead of the full path #include <executorch/kernels/portable/cpu/selected_op_variants.h> Note: expose_operator_symbols=False only works in xplat, so add a failure message for that too. I don't think we should recommend for users to set it to true, as it prevents a library from linking multiple executorch_generated_libs (symbols will clash). Differential Revision: [D75082395](https://our.internmc.facebook.com/intern/diff/D75082395/) [ghstack-poisoned]
2 parents b1b777c + b38e5c2 commit 2552c0b

File tree

1 file changed

+1
-0
lines changed

1 file changed

+1
-0
lines changed

shim_et/xplat/executorch/codegen/codegen.bzl

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -644,6 +644,7 @@ def executorch_generated_lib(
644644

645645
if dtype_selective_build:
646646
if not expose_operator_symbols and not is_xplat():
647+
# TODO(T225169282): make this a fail once internal cases move to xplat.
647648
warning("""
648649
Dtype selective build with expose_operator_symbols=False works only in xplat -
649650
there are undefined symbols otherwise. Please try to use xplat, or talk to the

0 commit comments

Comments
 (0)