Skip to content

Commit 21aa6ee

Browse files
authored
Fail the benchmark job if the export step fails (#8786)
* Fail the benchmark job if the export step fails * Try to run it in the test phase * Ready for review
1 parent a0c0d2b commit 21aa6ee

File tree

4 files changed

+13
-4
lines changed

4 files changed

+13
-4
lines changed

.github/workflows/android-perf.yml

+2-2
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@ on:
2020
description: Models to be benchmarked
2121
required: false
2222
type: string
23-
default: stories110M
23+
default: llama
2424
devices:
2525
description: Target devices to run benchmark
2626
required: false
@@ -36,7 +36,7 @@ on:
3636
description: Models to be benchmarked
3737
required: false
3838
type: string
39-
default: stories110M
39+
default: llama
4040
devices:
4141
description: Target devices to run benchmark
4242
required: false

.github/workflows/apple-perf.yml

+2-2
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@ on:
2020
description: Models to be benchmarked
2121
required: false
2222
type: string
23-
default: stories110M
23+
default: llama
2424
devices:
2525
description: Target devices to run benchmark
2626
required: false
@@ -36,7 +36,7 @@ on:
3636
description: Models to be benchmarked
3737
required: false
3838
type: string
39-
default: stories110M
39+
default: llama
4040
devices:
4141
description: Target devices to run benchmark
4242
required: false

extension/benchmark/android/benchmark/android-llm-device-farm-test-spec.yml.j2

+4
Original file line numberDiff line numberDiff line change
@@ -35,6 +35,10 @@ phases:
3535

3636
test:
3737
commands:
38+
# Fail the test if the model doesn't exist, doing it here so that AWS can report the status back
39+
- echo "Verify model"
40+
- curl -I --fail '{{ model_path }}' || false
41+
3842
# By default, the following ADB command is used by Device Farm to run your Instrumentation test.
3943
# Please refer to Android's documentation for more options on running instrumentation tests with adb:
4044
# https://developer.android.com/studio/test/command-line#run-tests-with-adb

extension/benchmark/apple/Benchmark/default-ios-device-farm-appium-test-spec.yml.j2

+5
Original file line numberDiff line numberDiff line change
@@ -34,6 +34,11 @@ phases:
3434
# The test phase includes commands that run your test suite execution.
3535
test:
3636
commands:
37+
# Fail the test if the model doesn't exist, doing it here so that AWS can report the status back
38+
- echo "Verify model"
39+
- curl -I --fail '{{ model_path }}' || false
40+
41+
# Run the benchmark
3742
- xcodebuild test-without-building -destination id=$DEVICEFARM_DEVICE_UDID -xctestrun $DEVICEFARM_TEST_PACKAGE_PATH/*.xctestrun -derivedDataPath $DEVICEFARM_LOG_DIR
3843

3944
# The post test phase includes are commands that are run after your tests are executed.

0 commit comments

Comments
 (0)