Skip to content

Commit 15c271e

Browse files
author
morelos
committed
[ET-VK][Ops] aten.tan.default in unary_ops
Pull Request resolved: #11047 Adds tan to unary_ops, as it doesn't already exist ghstack-source-id: 285689589 Differential Revision: [D75112807](https://our.internmc.facebook.com/intern/diff/D75112807/)
1 parent a3e0b77 commit 15c271e

File tree

6 files changed

+5
-153
lines changed

6 files changed

+5
-153
lines changed

backends/vulkan/runtime/graph/ops/glsl/tan.glsl

Lines changed: 0 additions & 60 deletions
This file was deleted.

backends/vulkan/runtime/graph/ops/glsl/tan.yaml

Lines changed: 0 additions & 13 deletions
This file was deleted.

backends/vulkan/runtime/graph/ops/glsl/unary_op.yaml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -46,3 +46,5 @@ unary_op:
4646
OPERATOR: leaky_relu(X, A)
4747
- NAME: round
4848
OPERATOR: round(X)
49+
- NAME: tan
50+
OPERATOR: tan(X)

backends/vulkan/runtime/graph/ops/impl/Tan.cpp

Lines changed: 0 additions & 64 deletions
This file was deleted.

backends/vulkan/runtime/graph/ops/impl/UnaryOp.cpp

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -154,6 +154,7 @@ DEFINE_ACTIVATION_FN(hardswish);
154154
DEFINE_ACTIVATION_FN(hardsigmoid);
155155
DEFINE_LEAKY_RELU_FN(leaky_relu);
156156
DEFINE_ACTIVATION_FN(round);
157+
DEFINE_ACTIVATION_FN(tan);
157158

158159
REGISTER_OPERATORS {
159160
VK_REGISTER_OP(aten.abs.default, abs);
@@ -174,6 +175,7 @@ REGISTER_OPERATORS {
174175
VK_REGISTER_OP(aten.hardsigmoid.default, hardsigmoid);
175176
VK_REGISTER_OP(aten.leaky_relu.default, leaky_relu);
176177
VK_REGISTER_OP(aten.round.default, round);
178+
VK_REGISTER_OP(aten.tan.default, tan);
177179
}
178180

179181
} // namespace vkcompute

backends/vulkan/test/op_tests/cases.py

Lines changed: 1 addition & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -1147,6 +1147,7 @@ def get_reduce_op_inputs():
11471147
"aten.hardsigmoid.default",
11481148
"aten.leaky_relu.default",
11491149
"aten.round.default",
1150+
"aten.tan.default",
11501151
]
11511152
)
11521153
def get_unary_ops_inputs():
@@ -1164,22 +1165,6 @@ def get_unary_ops_inputs():
11641165
return test_suite
11651166

11661167

1167-
# separate test suite from unary_ops for learning purposes
1168-
@register_test_suite("aten.tan.default")
1169-
def get_tan_inputs():
1170-
test_suite = VkTestSuite(
1171-
[
1172-
(M1,),
1173-
(M1, M2),
1174-
(S1, M1, M2),
1175-
(S1, S2, S2, M2),
1176-
]
1177-
)
1178-
test_suite.storage_types = ["utils::kTexture3D", "utils::kBuffer"]
1179-
test_suite.dtypes = ["at::kFloat"]
1180-
return test_suite
1181-
1182-
11831168
@register_test_suite("aten._native_batch_norm_legit_no_training.default")
11841169
def get_native_batch_norm_inputs():
11851170
Test = namedtuple(

0 commit comments

Comments
 (0)