Don't default to -fno-exceptions -fno-rtti

swolchok · swolchok · commit 0220a49eca24 · 2025-01-23T10:49:55.000-08:00
We need exceptions/RTTI for non-core-only use cases (see #7736). Sending first version of this without patching any specific targets to restore these flags because I want to see if anything actually breaks. ghstack-source-id: 15560f2 ghstack-comment-id: 2599307626 Pull Request resolved: #7746
diff --git a/CMakeLists.txt b/CMakeLists.txt
@@ -149,7 +149,7 @@ endif()
 # they can be properly gc'd. -s: strip symbol. -fno-exceptions -fno-rtti:
 # disables exceptions and runtime type.
 set(CMAKE_CXX_FLAGS_RELEASE
-    "-ffunction-sections -fdata-sections -fno-exceptions -fno-rtti ${CMAKE_CXX_FLAGS_RELEASE}"
+    "-ffunction-sections -fdata-sections ${CMAKE_CXX_FLAGS_RELEASE}"
 )
 if(CMAKE_CXX_COMPILER_ID STREQUAL "GNU")
   set(CMAKE_CXX_FLAGS_RELEASE "${CMAKE_CXX_FLAGS_RELEASE} -s")

Original file line number	Diff line number	Diff line change
`@@ -149,7 +149,7 @@ endif()`
`149`	`149`	`# they can be properly gc'd. -s: strip symbol. -fno-exceptions -fno-rtti:`
`150`	`150`	`# disables exceptions and runtime type.`
`151`	`151`	`set(CMAKE_CXX_FLAGS_RELEASE`
`152`		`- "-ffunction-sections -fdata-sections -fno-exceptions -fno-rtti ${CMAKE_CXX_FLAGS_RELEASE}"`
	`152`	`+ "-ffunction-sections -fdata-sections ${CMAKE_CXX_FLAGS_RELEASE}"`
`153`	`153`	`)`
`154`	`154`	`if(CMAKE_CXX_COMPILER_ID STREQUAL "GNU")`
`155`	`155`	`set(CMAKE_CXX_FLAGS_RELEASE "${CMAKE_CXX_FLAGS_RELEASE} -s")`