Add code to regenerate RECORD file for the wheel after we use patchelf #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
thanks a ton mate!!! |
peterjc123
referenced
this pull request
in peterjc123/builder
Apr 28, 2019
# This is the 1st commit message: # This is a combination of 16 commits. # This is the 1st commit message: . # This is the commit message #2: Enable wheel tests # This is the commit message #3: Remove useless % # This is the commit message #4: Debug CPU conda # This is the commit message #5: . # This is the commit message #6: . # This is the commit message #7: Revert debugging stuff # This is the commit message #8: . # This is the commit message #9: Revert to normal # This is the commit message #10: Revert to legacy version # This is the commit message #11: Disable all except CPU conda # This is the commit message #12: Explicit python version # This is the commit message #13: Revert "Explicit python version" This reverts commit a45b285. # This is the commit message #14: Revert "Disable all except CPU conda" This reverts commit 2c69de7. # This is the commit message #15: Use branches first # This is the commit message #16: Use hash # This is the commit message #2: . # This is the commit message #3: .
soumith
pushed a commit
that referenced
this pull request
Apr 28, 2019
# This is the 1st commit message: # This is a combination of 16 commits. # This is the 1st commit message: . # This is the commit message #2: Enable wheel tests # This is the commit message #3: Remove useless % # This is the commit message #4: Debug CPU conda # This is the commit message #5: . # This is the commit message #6: . # This is the commit message #7: Revert debugging stuff # This is the commit message #8: . # This is the commit message #9: Revert to normal # This is the commit message #10: Revert to legacy version # This is the commit message #11: Disable all except CPU conda # This is the commit message #12: Explicit python version # This is the commit message #13: Revert "Explicit python version" This reverts commit a45b285. # This is the commit message #14: Revert "Disable all except CPU conda" This reverts commit 2c69de7. # This is the commit message #15: Use branches first # This is the commit message #16: Use hash # This is the commit message #2: . # This is the commit message #3: .
jataylo
pushed a commit
to jataylo/builder
that referenced
this pull request
Sep 5, 2022
* Changes to support ROCm 5.3 * Updated as per comments
jataylo
pushed a commit
to jataylo/builder
that referenced
this pull request
Oct 10, 2022
* Changes to support ROCm 5.3 * Updated as per comments
malfet
pushed a commit
that referenced
this pull request
Oct 17, 2022
* Updates to support rocm5.3 wheel builds (#6) * Changes to support ROCm 5.3 * Updated as per comments * Installing python before magma build - In ROCm 5.3 libtorch build are failing during magma build due to to missing python binary so added install statement * Move python install to libtorch/Dockerfile (#8) * Updating the condition for noRCCL build (#9) * Updating the condition for noRCCL build * Updated changes as per comments * Use MIOpen branch for ROCm5.3; Change all conditions to -eq * Use staging branch of MIOpen for ROCm5.3 * Fix merge conflict Fix merge conflict Co-authored-by: Pruthvi Madugundu <pmagundu@amd.com> Co-authored-by: Pruthvi Madugundu <pruthvigithub@gmail.com> Co-authored-by: Jithun Nair <37884920+jithunnair-amd@users.noreply.github.com> Co-authored-by: Jithun Nair <jithun.nair@amd.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A fix for the broken
RECORDfiles in the wheel (pytorch/pytorch#2596)This code should re-generate the web-safe SHA256 hashes and overwrite the current
RECORDfilecc @soumith