You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Set seed in test_learned_preference_objective to stop it from flaking (#2145)
Summary:
## Motivation
* The test was flaky due to a varying amount of numerical error depending on random inputs, so I set a seed to a random number between 0 and 10
* Changed some data to double precision to avoid a warning
Pull Request resolved: #2145
Test Plan:
* checked that the test passes for each seed between 0 and 10
* I confirmed that there are seeds that do cause it to fail
* Increased the number of samples a lot to confirm that numerical error because small when the number of samples is large -- in other words, the error is due to a low number of samples
Reviewed By: Balandat
Differential Revision: D52002349
Pulled By: esantorella
fbshipit-source-id: c1908bdf649db0d51c8e8c2806b9e55258ffb855
0 commit comments