Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move Tacotron2 out of prototype #1714

Merged
merged 1 commit into from
Aug 18, 2021
Merged

Move Tacotron2 out of prototype #1714

merged 1 commit into from
Aug 18, 2021

Conversation

yangarbiter
Copy link
Contributor

@yangarbiter yangarbiter commented Aug 17, 2021 •
edited
Loading

Move Tacotron2 out of prototype folder to make it available as a beta feature

  • move Tacotron2 into models
  • correct imports from torchaudio.prototype.tacotron2 to torchaudio.models

@yangarbiter yangarbiter force-pushed the tacotron2_beta branch 5 times, most recently from e1dad21 to fa1b00b Compare August 17, 2021 20:34
mthrok
mthrok reviewed Aug 17, 2021
View reviewed changes
Copy link
Collaborator

@mthrok mthrok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change looks good to me so far.
Are there any tests that has to be moved?

mthrok
mthrok approved these changes Aug 17, 2021
View reviewed changes
Copy link
Collaborator

@mthrok mthrok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yangarbiter
Copy link
Contributor Author

The change looks good to me so far.
Are there any tests that has to be moved?

The tests are already in the test/torchaudio_unittest/models/ directory so no need to move it again.
Thanks.

@yangarbiter yangarbiter merged commit 352d63c into pytorch:main Aug 18, 2021
mthrok added a commit to mthrok/audio that referenced this pull request Dec 13, 2022
@mthrok @brianjo
Add speech recognition tutorial (pytorch#1714)
2c599be 
* Update build.sh

* Update audio tutorial (pytorch#1713)

* Update audio tutorial

* fix

* Add speech recognition tutorial

* update title

* Fix some

* Apply suggestions from code review

Co-authored-by: Caroline Chen <carolinechen@fb.com>

* Update intermediate_source/speech_recognition_pipeline_tutorial.py

* Update intermediate_source/speech_recognition_pipeline_tutorial.py

* Update intermediate_source/speech_recognition_pipeline_tutorial.py

* Add link to the tutorial page

* Fix

Co-authored-by: Brian Johnson <brianjo@fb.com>
Co-authored-by: Caroline Chen <carolinechen@fb.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mthrok mthrok mthrok approved these changes

Assignees
No one assigned
Labels
CLA Signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yangarbiter @mthrok @facebook-github-bot