Skip to content

Scale transform does not fail on non-integers #144

Closed
@vincentqb

Description

@vincentqb

Since Scale assumes integer-valued float-typed signal, giving a float-valued float-typed signal results is not what one would expect for a float-valued float-typed signal. We could either

  • update Scale to take float-valued float-typed,
  • give a warning if float-valued are detected happens,
  • we could rename the transform to IntegerScale, and introduce another FloatScale for this, with a deprecation warning.

The documentation does highlight this property, so we could also leave it at that. :)

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions