f8 roofline: make utils reusable #731
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: Moves the float8 roofline gemm and memory traffic utils to `torchao.float8.roofline_utils`, so they can be reused in other places. For now, I want to use this in ao_benchmarks. Test Plan: ``` python benchmarks/float8/float8_roofline.py ~/local/tmp/test.txt --gemm_time_strategy roofline ``` Reviewers: Subscribers: Tasks: Tags:
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/ao/731
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 86d4c77 with merge base 8002099 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
drisspg
approved these changes
Aug 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Moves the float8 roofline gemm and memory traffic utils to
torchao.float8.roofline_utils, so they can be reused in other places.For now, I want to use this in ao_benchmarks.
Test Plan:
Reviewers:
Subscribers:
Tasks:
Tags: