Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove torchao_nightly package #661

Merged
merged 3 commits into from
Aug 16, 2024

Conversation

atalman
Copy link
Contributor

@atalman atalman commented Aug 12, 2024

Final nightly package name similar to this: torchao-0.4.0.dev20240812+cpu-cp39-cp39-manylinux_2_17_x86_64.manylinux2014_x86_64.whl

Copy link

pytorch-bot bot commented Aug 12, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/ao/661

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 877acd3 with merge base accbdba (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Aug 12, 2024
@@ -10,7 +10,7 @@

from setuptools import find_packages, setup

current_date = datetime.now().strftime("%Y.%m.%d")
current_date = datetime.now().strftime("%Y%m%d")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

heads up to @joecummings and @ebsmothers in case you have version guards on nightly date

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, we'll catch and fix

@msaroufim
Copy link
Member

msaroufim commented Aug 12, 2024

Feel free to merge whenever you're ready @atalman - presumably the right test plan is to trigger this once and see all the published nightly binaries for today on the pytorch index and kill torchao-nightly pypi?

@joecummings
Copy link

When this does land @atalman, can you ping me so I can fix our tests real quick?

@jerryzh168
Copy link
Contributor

does pip install torchao-nightly work after this PR?

@atalman atalman merged commit 4082008 into pytorch:main Aug 16, 2024
23 checks passed
@atalman atalman deleted the remove_torchao_nightly_package branch August 16, 2024 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants