Fixing cuda device check #536
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/ao/536
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit e755763 with merge base e5df48e ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
Summary: Previous cuda device check is not general enough, this adds a better check that works for more cases like "cuda:0" Test Plan: python test/quantization/test_quant_api.py -k test_int4wo_quantized_model_to_device Reviewers: Subscribers: Tasks: Tags:
jerryzh168
force-pushed
the
cuda-device-check
branch
from
8d66d0e
to
e755763
Compare
msaroufim
approved these changes
Jul 25, 2024
Hanxian97
pushed a commit
that referenced
this pull request
Jul 29, 2024
Summary: Previous cuda device check is not general enough, this adds a better check that works for more cases like "cuda:0" Test Plan: python test/quantization/test_quant_api.py -k test_int4wo_quantized_model_to_device Reviewers: Subscribers: Tasks: Tags:
dbyoung18
pushed a commit
to dbyoung18/ao
that referenced
this pull request
Jul 31, 2024
Summary: Previous cuda device check is not general enough, this adds a better check that works for more cases like "cuda:0" Test Plan: python test/quantization/test_quant_api.py -k test_int4wo_quantized_model_to_device Reviewers: Subscribers: Tasks: Tags:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Previous cuda device check is not general enough, this adds a better check that works for more cases like "cuda:0"
Test Plan:
python test/quantization/test_quant_api.py -k test_int4wo_quantized_model_to_device
(local test with
pip install torch==2.5.0.dev20240630 --extra-index-url https://download.pytorch.org/whl/nightly/cu121)Reviewers:
Subscribers:
Tasks:
Tags: