Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add FP8 Adam #482

Merged
merged 14 commits into from
Jul 7, 2024
Merged

Add FP8 Adam #482

merged 14 commits into from
Jul 7, 2024

Conversation

gau-nernst
Copy link
Collaborator

Add FP8 Adam backed by the native torch.float8_e4m3fn dtype to utilize hardware instructions for dtype casting.

Copy link

pytorch-bot bot commented Jul 6, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/ao/482

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit b0fe51d with merge base 56d46a2 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jul 6, 2024
@msaroufim msaroufim self-requested a review July 7, 2024 18:57
@msaroufim msaroufim merged commit 12ac498 into pytorch:main Jul 7, 2024
13 checks passed
@gau-nernst gau-nernst deleted the adam_fp8 branch July 7, 2024 20:19
dbyoung18 pushed a commit to dbyoung18/ao that referenced this pull request Jul 31, 2024
* update benchmark

* add rank1 option to lpmm

* add comma

* update readme

* remove unwanted file

* update

* add Adam fp8

* add FP8 AdamW and test

* update readme

* change reason to xfail, since 2.2 also have float8

* at guard for FP8

* update readme

* fix guard
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants