Refactor the API for quant method argument for quantize function #400
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/ao/400
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 20a2938 with merge base 512b5d6 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
msaroufim
reviewed
Jun 19, 2024
test/integration/test_integration.py
Outdated
| int8da_int8w, | ||
| int4_weight_only, | ||
| int8_weight_only, | ||
| int8_dynamic_act_int8_weight, |
There was a problem hiding this comment.
can we expand out act into activation as well? Might as well since we hardly have any abbreviations left
|
can you also include the update to the main README as well in this PR - specifically the snippet in https://github.com/pytorch/ao?tab=readme-ov-file#without-intrusive-code-changes |
jerryzh168
force-pushed
the
api-refactor
branch
2 times, most recently
from
28680ff
to
e27b898
Compare
vayuda
approved these changes
Jun 19, 2024
jerryzh168
force-pushed
the
api-refactor
branch
2 times, most recently
from
5fb966d
to
91a6dc5
Compare
Summary: Addressing feedback from pytorch#384 and pytorch#375 Test Plan: regression tests python test/quantization/test_quant_api.py python test/integration/test_integration.py Reviewers: Subscribers: Tasks: Tags:
jerryzh168
added a commit
to jerryzh168/ao
that referenced
this pull request
Jun 25, 2024
Summary: * added repr for TensorCoreTiledAQTLayoutTensor: pytorch#397 * removed the str -> apply_tensor_class map that was used to implement string APIs, which is removed in pytorch#400 Test Plan: CI Reviewers: Subscribers: Tasks: Tags:
jerryzh168
added a commit
to jerryzh168/ao
that referenced
this pull request
Jun 25, 2024
Summary: * added repr for TensorCoreTiledAQTLayoutTensor: pytorch#397 * removed the str -> apply_tensor_class map that was used to implement string APIs, which is removed in pytorch#400 Test Plan: CI Reviewers: Subscribers: Tasks: Tags:
jerryzh168
added a commit
that referenced
this pull request
Jun 26, 2024
dbyoung18
pushed a commit
to dbyoung18/ao
that referenced
this pull request
Jul 31, 2024
…orch#400) Summary: Addressing feedback from pytorch#384 and pytorch#375 Test Plan: regression tests python test/quantization/test_quant_api.py python test/integration/test_integration.py Reviewers: Subscribers: Tasks: Tags:
dbyoung18
pushed a commit
to dbyoung18/ao
that referenced
this pull request
Jul 31, 2024
Summary: * added repr for TensorCoreTiledAQTLayoutTensor: pytorch#397 * removed the str -> apply_tensor_class map that was used to implement string APIs, which is removed in pytorch#400 Test Plan: CI Reviewers: Subscribers: Tasks: Tags:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Addressing feedback from #384 and #375
Test Plan:
regression tests
python test/quantization/test_quant_api.py
python test/integration/test_integration.py
Reviewers:
Subscribers:
Tasks:
Tags: