Skip depending on torch testing package #235
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: We used to do ``` from torch.testing._internal.common_utils import IS_FBCODE ``` but this caused some internal failures, so we'll just copy paste the code for `IS_FBCODE` so that we don't depend on the testing package Test Plan: internal CI Reviewers: Subscribers: Tasks: Tags:
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/ao/235
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit e06b4f6 with merge base 0c5c814 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
cpuhrsch
approved these changes
May 9, 2024
albanD
approved these changes
May 9, 2024
it's just because we have make rules for cuda kernels only in OSS, and not sure how to write the equivalent make rules in fbcode |
dbyoung18
pushed a commit
to dbyoung18/ao
that referenced
this pull request
Jul 31, 2024
Summary: We used to do ``` from torch.testing._internal.common_utils import IS_FBCODE ``` but this caused some internal failures, so we'll just copy paste the code for `IS_FBCODE` so that we don't depend on the testing package Test Plan: internal CI Reviewers: Subscribers: Tasks: Tags:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
We used to do
but this caused some internal failures, so we'll just copy paste the code for
IS_FBCODEso that we don't depend on the testing packageTest Plan:
internal CI
Reviewers:
Subscribers:
Tasks:
Tags: