-
Notifications
You must be signed in to change notification settings - Fork 283
Add Tutorial on E2E integration into VLLM and minimal Subclass #2346
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/ao/2346
Note: Links to docs will display an error until the docs builds have been completed. This comment was automatically generated by Dr. CI and updates every 15 minutes. |
stack-info: PR: #2346, branch: drisspg/stack/75
8e87fe2
to
32bec8a
Compare
@andrewor14 do tutorials/md files automagically get put into our docs? |
No you need to put them under docs/ |
Actually I think this tutorial belongs better to the docs page :). The tutorials/ folder is not super visible. I don't imagine people will purposefully click into it and stumble upon this highly important tutorial, so maybe move it to the docs page instead? Unfortunately this means you will need to convert the markdown here to rst format |
@svekars I remember you mentioned that we can use Markdown isntead of RST to write docs, is that true? |
stack-info: PR: #2346, branch: drisspg/stack/75
32bec8a
to
77cac8f
Compare
stack-info: PR: #2346, branch: drisspg/stack/75
77cac8f
to
7f13c3f
Compare
stack-info: PR: #2346, branch: drisspg/stack/75
7f13c3f
to
eab15b7
Compare
stack-info: PR: #2346, branch: drisspg/stack/75
eab15b7
to
1badf8b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great!
1badf8b
to
bcc6797
Compare
bcc6797
to
399551a
Compare
stack-info: PR: #2346, branch: drisspg/stack/75
399551a
to
6284817
Compare
Stacked PRs:
Add Tutorial on E2E integration into VLLM and minimal Subclass