Skip to content

Add Tutorial on E2E integration into VLLM and minimal Subclass #2346

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 12, 2025

Conversation

drisspg
Copy link
Contributor

@drisspg drisspg commented Jun 10, 2025

Stacked PRs:


Add Tutorial on E2E integration into VLLM and minimal Subclass

Copy link

pytorch-bot bot commented Jun 10, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/ao/2346

Note: Links to docs will display an error until the docs builds have been completed.

This comment was automatically generated by Dr. CI and updates every 15 minutes.

drisspg added a commit that referenced this pull request Jun 10, 2025
@drisspg drisspg force-pushed the drisspg/stack/75 branch from 8e87fe2 to 32bec8a Compare June 10, 2025 02:40
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jun 10, 2025
@drisspg drisspg requested a review from jerryzh168 June 10, 2025 02:41
@drisspg drisspg added the topic: documentation Use this tag if this PR adds or improves documentation label Jun 10, 2025
@drisspg drisspg requested a review from andrewor14 June 10, 2025 15:24
@drisspg
Copy link
Contributor Author

drisspg commented Jun 10, 2025

@andrewor14 do tutorials/md files automagically get put into our docs?

@andrewor14
Copy link
Contributor

@andrewor14 do tutorials/md files automagically get put into our docs?

No you need to put them under docs/

@andrewor14
Copy link
Contributor

Actually I think this tutorial belongs better to the docs page :). The tutorials/ folder is not super visible. I don't imagine people will purposefully click into it and stumble upon this highly important tutorial, so maybe move it to the docs page instead? Unfortunately this means you will need to convert the markdown here to rst format

@drisspg
Copy link
Contributor Author

drisspg commented Jun 10, 2025

@svekars I remember you mentioned that we can use Markdown isntead of RST to write docs, is that true?

drisspg added a commit that referenced this pull request Jun 10, 2025
@drisspg drisspg force-pushed the drisspg/stack/75 branch from 32bec8a to 77cac8f Compare June 10, 2025 18:35
drisspg added a commit that referenced this pull request Jun 10, 2025
@drisspg drisspg force-pushed the drisspg/stack/75 branch from 77cac8f to 7f13c3f Compare June 10, 2025 23:21
drisspg added a commit that referenced this pull request Jun 11, 2025
@drisspg drisspg force-pushed the drisspg/stack/75 branch from 7f13c3f to eab15b7 Compare June 11, 2025 19:55
drisspg added a commit that referenced this pull request Jun 11, 2025
@drisspg drisspg force-pushed the drisspg/stack/75 branch from eab15b7 to 1badf8b Compare June 11, 2025 20:36
Copy link
Contributor

@andrewor14 andrewor14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@drisspg drisspg force-pushed the drisspg/stack/75 branch from 399551a to 6284817 Compare June 12, 2025 03:11
@drisspg drisspg merged commit eaaf787 into main Jun 12, 2025
19 of 21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. topic: documentation Use this tag if this PR adds or improves documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants