Skip to content

Uses torch.version.cuda to compile CUDA extensions #2193

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 9, 2025

Conversation

syed-ahmed
Copy link
Contributor

@atalman the changes in #2170 removed my changes from #2163. Note that torch.cuda.is_available() fails in a system where CUDA toolkit is available for compilation but there are no GPUs. As a result, extension won't get compiled in that system.

Copy link

pytorch-bot bot commented May 9, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/ao/2193

Note: Links to docs will display an error until the docs builds have been completed.

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label May 9, 2025
Copy link
Contributor

@atalman atalman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@atalman atalman added the topic: not user facing Use this tag if you don't want this PR to show up in release notes label May 9, 2025
@atalman atalman merged commit 32b7cd1 into pytorch:main May 9, 2025
25 checks passed
andrewor14 pushed a commit that referenced this pull request May 9, 2025
* Uses torch.version.cuda to compile CUDA extensions

* lint
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. topic: not user facing Use this tag if you don't want this PR to show up in release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants