Claen up op interface #1998
Merged
Claen up op interface #1998
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: This PR adds mr based kernel selection, and cleans up the op interface. 1. Removes linear.h and uses the new channelwise_8bit_activation_groupwise_lowbit_weight.h we created in an earlier diff 2. Uses packed_weights_offset functions from ukernel, rather than manually computing the offset 3. Removes the compute policies (parallalel_mc_parallel_nc, single_mc_parallel_nc). Only one of these policies is needed, and having both complicated adding mr based kernel selection. 4. Moves UkernelConfig into its own file kernel_config.h from kernel_selection.h. 4. Adds mr-based kernel selection (select mr ukernel based on m). This is in prepearation for KleidiAI GEMM kernel selection (next diff). Reviewed By: Jack-Khuu Differential Revision: D72179480
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/ao/1998
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 New FailureAs of commit 43f7dbf with merge base 5e4d50c ( NEW FAILURE - The following job has failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D72179480 |
Jack-Khuu
approved these changes
Apr 1, 2025
jainapurva
pushed a commit
that referenced
this pull request
Apr 8, 2025
Differential Revision: D72179480 Pull Request resolved: #1998
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This PR adds mr based kernel selection, and cleans up the op interface.
Reviewed By: Jack-Khuu
Differential Revision: D72179480