Skip to content

Migrate to int args #1846

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 14 commits into from
Mar 11, 2025
Merged

Migrate to int args #1846

merged 14 commits into from
Mar 11, 2025

Conversation

metascroy
Copy link
Contributor

AOTI is now working with int args, so this migrates to using ints instead of tensors.

This should be reviewed after #1836 lands and I rebase. Most of the changes are from the other PR.

Copy link

pytorch-bot bot commented Mar 5, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/ao/1846

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure, 5 Pending

As of commit b13b51f with merge base f64d5a1 (image):

NEW FAILURE - The following job has failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@metascroy metascroy requested a review from digantdesai March 5, 2025 23:19
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Mar 5, 2025
@metascroy metascroy force-pushed the migrate-to-int-args branch 2 times, most recently from 6f196c2 to b04c93c Compare March 9, 2025 23:51
@metascroy metascroy requested a review from Jack-Khuu March 10, 2025 18:02
@metascroy metascroy force-pushed the migrate-to-int-args branch from c878faa to 35324f0 Compare March 10, 2025 20:00
@metascroy metascroy merged commit 1eb4d33 into main Mar 11, 2025
16 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants