Skip to content

add mxfp8_cublas recipe to mx_formats #1831

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Mar 5, 2025
Merged

add mxfp8_cublas recipe to mx_formats #1831

merged 10 commits into from
Mar 5, 2025

Conversation

vkuzo
Copy link
Contributor

@vkuzo vkuzo commented Mar 4, 2025

Summary:

Adds an mxfp8 recipe backed by torch._scaled_mm's cuBLAS kernel. Note that torch.compile does not work for this yet.

Test Plan: CI

Reviewers:

Subscribers:

Tasks:

Tags:

vkuzo added 3 commits March 4, 2025 12:53
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
@vkuzo
Copy link
Contributor Author

vkuzo commented Mar 4, 2025

Copy link

pytorch-bot bot commented Mar 4, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/ao/1831

Note: Links to docs will display an error until the docs builds have been completed.

This comment was automatically generated by Dr. CI and updates every 15 minutes.

vkuzo added a commit that referenced this pull request Mar 4, 2025
Summary:

Test Plan:

Reviewers:

Subscribers:

Tasks:

Tags:

ghstack-source-id: 2040ca9c5f3bffdbac56909a0fcc48f6cab25e3e
ghstack-comment-id: 2698879489
Pull Request resolved: #1831
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Mar 4, 2025
[ghstack-poisoned]
vkuzo added a commit that referenced this pull request Mar 4, 2025
Summary:

Test Plan:

Reviewers:

Subscribers:

Tasks:

Tags:

ghstack-source-id: fa1b60ac3144de5e9bcf2ce922e7305500b66720
ghstack-comment-id: 2698879489
Pull Request resolved: #1831
@vkuzo vkuzo requested review from drisspg and danielvegamyhre March 4, 2025 20:58
@vkuzo vkuzo added the topic: not user facing Use this tag if you don't want this PR to show up in release notes label Mar 4, 2025
vkuzo added 2 commits March 4, 2025 13:00
[ghstack-poisoned]
[ghstack-poisoned]
vkuzo added a commit that referenced this pull request Mar 4, 2025
Summary:

Test Plan:

Reviewers:

Subscribers:

Tasks:

Tags:

ghstack-source-id: 244b2570eea370264466aebbf76c3f1e02c81fd8
ghstack-comment-id: 2698879489
Pull Request resolved: #1831
vkuzo added 3 commits March 5, 2025 06:39
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
@vkuzo vkuzo changed the base branch from gh/vkuzo/50/head to main March 5, 2025 14:40
[ghstack-poisoned]
@vkuzo vkuzo merged commit 23c3162 into main Mar 5, 2025
41 of 45 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. topic: not user facing Use this tag if you don't want this PR to show up in release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants