-
Notifications
You must be signed in to change notification settings - Fork 257
add mxfp8_cublas recipe to mx_formats #1831
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Stack from ghstack (oldest at bottom): |
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/ao/1831
Note: Links to docs will display an error until the docs builds have been completed. This comment was automatically generated by Dr. CI and updates every 15 minutes. |
vkuzo
added a commit
that referenced
this pull request
Mar 4, 2025
Summary: Test Plan: Reviewers: Subscribers: Tasks: Tags: ghstack-source-id: 2040ca9c5f3bffdbac56909a0fcc48f6cab25e3e ghstack-comment-id: 2698879489 Pull Request resolved: #1831
vkuzo
added a commit
that referenced
this pull request
Mar 4, 2025
Summary: Test Plan: Reviewers: Subscribers: Tasks: Tags: ghstack-source-id: fa1b60ac3144de5e9bcf2ce922e7305500b66720 ghstack-comment-id: 2698879489 Pull Request resolved: #1831
vkuzo
added a commit
that referenced
this pull request
Mar 4, 2025
Summary: Test Plan: Reviewers: Subscribers: Tasks: Tags: ghstack-source-id: 244b2570eea370264466aebbf76c3f1e02c81fd8 ghstack-comment-id: 2698879489 Pull Request resolved: #1831
drisspg
approved these changes
Mar 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
CLA Signed
This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
topic: not user facing
Use this tag if you don't want this PR to show up in release notes
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Adds an mxfp8 recipe backed by
torch._scaled_mm
's cuBLAS kernel. Note that torch.compile does not work for this yet.Test Plan: CI
Reviewers:
Subscribers:
Tasks:
Tags: