Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add A10G support in CI #176

Merged
merged 20 commits into from
Apr 25, 2024
Merged

Add A10G support in CI #176

merged 20 commits into from
Apr 25, 2024

Conversation

msaroufim
Copy link
Member

@msaroufim msaroufim commented Apr 25, 2024

Support A10G + manylinux so cuda extensions work on as many systems as possible

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Apr 25, 2024
@@ -449,6 +449,7 @@ def test_dynamic_quant_per_tensor_numerics_cpu(self):
for row in test_cases:
self._test_dynamic_quant_per_tensor_numerics_impl(*row)

@unittest.skip("test case incorrect on A10G")
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@msaroufim msaroufim requested a review from cpuhrsch April 25, 2024 21:10
@@ -1381,6 +1392,8 @@ def test_autoquant_one_input(self, device, dtype, m, k, n):
(32, 32, 128, 128),
]))
@unittest.skipIf(not TORCH_VERSION_AFTER_2_3, "autoquant requires 2.3+.")
@unittest.skipIf(TORCH_VERSION_AFTER_2_4 and torch.cuda.is_available(), "SystemError: AST constructor recursion depth mismatch (before=45, after=84)")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this fail for all dtypes etc.?

@msaroufim msaroufim merged commit bc462dd into main Apr 25, 2024
13 checks passed
@msaroufim msaroufim deleted the msaroufim/a10g branch April 25, 2024 22:46
dbyoung18 pushed a commit to dbyoung18/ao that referenced this pull request Jul 31, 2024
* Add A10G support in CI

* push

* push

* push

* push

* push

* push

* push

* push

* push

* push

* Convert to utilize linux_job.yml

* switch to use linux.4xlarge

* no more need for GPU checks

* push

* this feels gross

* push

* push

* push

---------

Co-authored-by: Eli Uriegas <1700823+seemethere@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants