Skip to content

Update cmake files #1070

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 15, 2024
Merged

Update cmake files #1070

merged 2 commits into from
Oct 15, 2024

Conversation

metascroy
Copy link
Contributor

Main updates are:

  • Add config file so that torchao can be used by find_package
  • Rename TORCHAO_OP_EXECUTORCH_BUILD to TORCHAO_BUILD_EXECUTORCH_OPS
  • Rename BUILD_KLEIDI to TORCHAO_BUILD_KLEIDIAI (and guard fetchcontent behind this)
  • Use GLOB for op_linear_8bit_act_xbit_weight_executorch

Test plan:

sh build_torchao_ops.sh executorch
python tests/test_linear_8bit_act_xbit_weight_quantizer.py

Copy link

pytorch-bot bot commented Oct 14, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/ao/1070

Note: Links to docs will display an error until the docs builds have been completed.

✅ You can merge normally! (1 Unrelated Failure)

As of commit a3f52f0 with merge base e7b33bc (image):

BROKEN TRUNK - The following job failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Oct 14, 2024
@metascroy
Copy link
Contributor Author

@larryliu0820 I removed the cmake config from this PR. Did you have any other concerns?

@metascroy metascroy merged commit b53694a into main Oct 15, 2024
16 of 17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants