Skip to content

Simplify the Group Norm converter #3719

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 25, 2025
Merged

Simplify the Group Norm converter #3719

merged 1 commit into from
Jul 25, 2025

Conversation

zewenli98
Copy link
Collaborator

Description

Simplify the group norm converter

Fixes #3718

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • My code follows the style guidelines of this project (You can use the linters)
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas and hacks
  • I have made corresponding changes to the documentation
  • I have added tests to verify my fix or my feature
  • New and existing unit tests pass locally with my changes
  • I have added the relevant labels to my PR in so that relevant reviewers are notified

@zewenli98 zewenli98 self-assigned this Jul 25, 2025
@github-actions github-actions bot added component: conversion Issues re: Conversion stage component: converters Issues re: Specific op converters component: api [Python] Issues re: Python API component: dynamo Issues relating to the `torch.compile` or `torch._dynamo.export` paths labels Jul 25, 2025
peri044
peri044 approved these changes Jul 25, 2025
View reviewed changes
Copy link
Collaborator

@peri044 peri044 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@peri044 peri044 merged commit b00ff13 into main Jul 25, 2025
87 of 88 checks passed
@HolyWu HolyWu mentioned this pull request Jul 28, 2025
Open
@zewenli98 zewenli98 mentioned this pull request Jul 31, 2025
Merged
zewenli98 added a commit that referenced this pull request Aug 1, 2025
@zewenli98
Cherrypick #3719 for release/2.8 (#3734)
b65e445
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peri044 peri044 peri044 approved these changes

@narendasan narendasan Awaiting requested review from narendasan

@cehongwang cehongwang Awaiting requested review from cehongwang

Assignees

@zewenli98 zewenli98

Labels
cla signed component: api [Python] Issues re: Python API component: conversion Issues re: Conversion stage component: converters Issues re: Specific op converters component: dynamo Issues relating to the `torch.compile` or `torch._dynamo.export` paths
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

🐛 [Bug] Torch-TRT's Group Norm is slower than ONNX-TRT
3 participants
@zewenli98 @peri044 @facebook-github-bot